Re: com php-src: Fixed bug #53829 Compiling PHP with large file support will replace function gzopen by gzopen64: NEWS ext/zlib/zlib.c

Hey, wouldn't it be better to use PHP_NAMED_* macros instead? On 12/11/14 11:21, Matteo Beccati wrote: > Commit: 65fee904622160781db05b0a469d67b4414cbd7f > Author: Matteo Beccati <mbeccati@php.net> Wed, 12 Nov 2014 11:21:11 +0100 > Parents: 14d3e173aa08765de2a053dd267c5beba8b872c9 > Branches: PHP-5.5 PHP-5.6 master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=65fee904622160781db05b0a469d67b4414cbd7f > > Log: > Fixed bug #53829 Compiling PHP with large file support will replace function gzopen by gzopen64 > > Bugs: > https://bugs.php.net/53829 > > Changed paths: > M NEWS > M ext/zlib/zlib.c > > > Diff: > diff --git a/NEWS b/NEWS > index 6c5cbe9..fa1ec8a 100644 > --- a/NEWS > +++ b/NEWS > @@ -5,6 +5,10 @@ PHP > NEWS > - Core: > . Fixed bug #68370 ("unset($this)" can make the program crash). (Laruence) > > +- zlib: > + . Fixed bug #53829 (Compiling PHP with large file support will replace > + function gzopen by gzopen64) (Sascha Kettler, Matteo) > + > 13 Nov 2014, PHP 5.5.19 > > - Core: > diff --git a/ext/zlib/zlib.c b/ext/zlib/zlib.c > index 705fb5d..2580459 100644 > --- a/ext/zlib/zlib.c > +++ b/ext/zlib/zlib.c > @@ -34,6 +34,18 @@ > #include "ext/standard/php_string.h" > #include "php_zlib.h" > > +/* > + * zlib include files can define the following preprocessor defines which rename > + * the corresponding PHP functions to gzopen64, gzseek64 and gztell64 and thereby > + * breaking some software, most notably PEAR's Archive_Tar, which halts execution > + * without error message on gzip compressed archivesa. > + * > + * This only seems to happen on 32bit systems with large file support. > + */ > +#undef gzopen > +#undef gzseek > +#undef gztell > + > ZEND_DECLARE_MODULE_GLOBALS(zlib); > > /* {{{ Memory management wrappers */ > > -- Regards, Mike