com php-src: Fix bug #68463 listen.allowed_clients can silently result in no allowed access: sapi/fpm/fp m/fastcgi.c

From: Date: Thu, 20 Nov 2014 14:14:34 +0000
Subject: com php-src: Fix bug #68463 listen.allowed_clients can silently result in no allowed access: sapi/fpm/fp m/fastcgi.c
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-83192@lists.php.net to get a copy of this message
Commit: 5c6ccb2d8f564ddfa3fff267b776036a0539b3b0 Author: Remi Collet <remi@php.net> Thu, 20 Nov 2014 15:14:34 +0100 Parents: 7ef559ff8038807156b01408bd215af7983adc5d Branches: PHP-5.6 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=5c6ccb2d8f564ddfa3fff267b776036a0539b3b0 Log: Fix bug #68463 listen.allowed_clients can silently result in no allowed access Add a "There are no allowed addresses for this pool" Bugs: https://bugs.php.net/68463 Changed paths: M sapi/fpm/fpm/fastcgi.c Diff: diff --git a/sapi/fpm/fpm/fastcgi.c b/sapi/fpm/fpm/fastcgi.c index 36e37b7..d2764a5 100644 --- a/sapi/fpm/fpm/fastcgi.c +++ b/sapi/fpm/fpm/fastcgi.c @@ -280,6 +280,10 @@ void fcgi_set_allowed_clients(char *ip) } allowed_clients[n].sa.sa_family = 0; free(ip); + if (!n) { + zlog(ZLOG_ERROR, "There are no allowed addresses for this pool"); + /* don't clear allowed_clients as it will create an "open for all" security issue */ + } } }

« previous php.cvs (#83192) next »