com php-src: Fix bug #68463 listen.allowed_clients can silently result in no allowed access: sapi/fpm/fp m/fastcgi.c

Commit: 5be75da2027ca9fe1726536ff68a5a8b3c31fa96 Author: Remi Collet <remi@php.net> Thu, 20 Nov 2014 15:14:34 +0100 Parents: c4ca220467a94ff361c6dbdec281b861c9d749be Branches: PHP-5.5 PHP-5.6 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=5be75da2027ca9fe1726536ff68a5a8b3c31fa96 Log: Fix bug #68463 listen.allowed_clients can silently result in no allowed access Add a "There are no allowed addresses for this pool" Bugs: https://bugs.php.net/68463 Changed paths: M sapi/fpm/fpm/fastcgi.c Diff: diff --git a/sapi/fpm/fpm/fastcgi.c b/sapi/fpm/fpm/fastcgi.c index 36e37b7..d2764a5 100644 --- a/sapi/fpm/fpm/fastcgi.c +++ b/sapi/fpm/fpm/fastcgi.c @@ -280,6 +280,10 @@ void fcgi_set_allowed_clients(char *ip) } allowed_clients[n].sa.sa_family = 0; free(ip); + if (!n) { + zlog(ZLOG_ERROR, "There are no allowed addresses for this pool"); + /* don't clear allowed_clients as it will create an "open for all" security issue */ + } } }