Re: com php-src: Fix bug #68446 (bug with constant defaults and type hints): Zend/tests/class_constants_002.phpt Zend/zend_compile.c
Zend/zend_execute.c Zend/zend_vm_def.h Zend/zend_vm_execute.h

Hey Dmitry, My changes shouldn't break code which isn't already fragile. class_constants_002.phpt is such an example. Though, I could restore old behavior and just evaluate in case a constant is passed _and_ there is an array/callable typehint. Would that be fine? In this case there wouldn't be any BC break (only already fatal-ing code working again). Thanks, Bob > Am 24.11.2014 um 09:26 schrieb Dmitry Stogov <dmitry@zend.com>: > > Hi Bob, > > Please, send such changes for review before committing. > > It is not a trivial change and it breaks existing behavior > (Zend/tests/class_constants_002.phpt). > Default values don't have to be evaluated, if actual parameter was sent. > Your patch may affect existing code in unpredictable way (e.g. start fail because of error or > trigger __autoload()). > Please, revert it. Such changes can't be done in minor releases. > Probably, the bug may be fixed in another way. > > Thanks. Dmitry. > > On Sun, Nov 23, 2014 at 11:10 PM, Bob Weinand <bwoebi@php.net > <mailto:bwoebi@php.net>> wrote: > Commit: 5ef138b0c7c4e9532e205f45c18a72aa1d279c24 > Author: Bob Weinand <bobwei9@hotmail.com > <mailto:bobwei9@hotmail.com>> Sun, 23 Nov 2014 > 21:09:31 +0100 > Parents: c8dd41554387e100a09811cad7f7032a291a79c2 > Branches: PHP-5.6 > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=5ef138b0c7c4e9532e205f45c18a72aa1d279c24 > <http://git.php.net/?p=php-src.git;a=commitdiff;h=5ef138b0c7c4e9532e205f45c18a72aa1d279c24> > > Log: > Fix bug #68446 (bug with constant defaults and type hints) > > Bugs: > https://bugs.php.net/68446 > <https://bugs.php.net/68446> > > Changed paths: > M Zend/tests/class_constants_002.phpt > M Zend/zend_compile.c > M Zend/zend_execute.c > M Zend/zend_vm_def.h > M Zend/zend_vm_execute.h > > > -- > PHP CVS Mailing List (http://www.php.net/ > <http://www.php.net/>) > To unsubscribe, visit: http://www.php.net/unsub.php > <http://www.php.net/unsub.php> >