Re: com php-src: Use zend_string_tolower in zif_strtolower: ext/standard/string.c

Hey: On Wed, Dec 24, 2014 at 9:43 PM, Nikita Popov <nikita.ppv@gmail.com> wrote: > On Wed, Dec 24, 2014 at 2:16 PM, Xinchen Hui <laruence@php.net> wrote: >> >> Commit: 06abeab50c00fce1e8f06a8a137d4760ac13acae >> Author: Xinchen Hui <laruence@php.net> Wed, 24 Dec 2014 >> 08:16:17 -0500 >> Parents: 231db90b28a6c469e412c59cc4218b35ce90ed84 >> Branches: master >> >> Link: >> >> http://git.php.net/?p=php-src.git;a=commitdiff;h=06abeab50c00fce1e8f06a8a137d4760ac13acae >> >> Log: >> Use zend_string_tolower in zif_strtolower >> >> Changed paths: >> M ext/standard/string.c >> >> >> Diff: >> diff --git a/ext/standard/string.c b/ext/standard/string.c >> index e275e64..344ac8a 100644 >> --- a/ext/standard/string.c >> +++ b/ext/standard/string.c >> @@ -1419,9 +1419,7 @@ PHP_FUNCTION(strtolower) >> ZEND_PARSE_PARAMETERS_END(); >> #endif >> >> - result = zend_string_init(str->val, str->len, 0); >> - php_strtolower(result->val, result->len); >> - RETURN_NEW_STR(result); >> + RETURN_STR(zend_string_tolower(str)); >> } >> /* }}} */ >> > > Isn't strtolower() supposed to be locale-aware? thanks! I oversight it.. we fix it now :) thanks > > Nikita > -- Xinchen Hui @Laruence http://www.laruence.com/