com php-src: Add missing string cast for non-cv var fetches: Zend/tests/variable_with_boolean_name.phpt Zend/zend _compile.c
| From: | Nikita Popov | Date: | Sun, 04 Jan 2015 17:07:44 +0000 |
| Subject: | com php-src: Add missing string cast for non-cv var fetches: Zend/tests/variable_with_boolean_name.phpt Zend/zend _compile.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-83965@lists.php.net to get a copy of this message | ||
Commit: 2269b1801d3e55d6895ff4c066e9f485c1f5ac2f
Author: Nikita Popov <nikic@php.net> Sun, 4 Jan 2015 18:07:44 +0100
Parents: 69a4b135f32108969f1a947a8bfdba3fcee967bb
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=2269b1801d3e55d6895ff4c066e9f485c1f5ac2f
Log:
Add missing string cast for non-cv var fetches
Changed paths:
A Zend/tests/variable_with_boolean_name.phpt
M Zend/zend_compile.c
Diff:
diff --git a/Zend/tests/variable_with_boolean_name.phpt b/Zend/tests/variable_with_boolean_name.phpt
new file mode 100644
index 0000000..e0daad5
--- /dev/null
+++ b/Zend/tests/variable_with_boolean_name.phpt
@@ -0,0 +1,13 @@
+--TEST--
+Variable with boolean name
+--FILE--
+<?php
+
+${true} = 42;
+var_dump(${true});
+var_dump(${'1'});
+
+?>
+--EXPECT--
+int(42)
+int(42)
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index 334d733..c06ebc4 100644
--- a/Zend/zend_compile.c
+++ b/Zend/zend_compile.c
@@ -1978,6 +1978,9 @@ static zend_op *zend_compile_simple_var_no_cv(znode *result, zend_ast *ast,
uint
}
zend_compile_expr(&name_node, name_ast);
+ if (name_node.op_type == IS_CONST) {
+ convert_to_string(&name_node.u.constant);
+ }
opline = zend_emit_op(result, ZEND_FETCH_R, &name_node, NULL);