com php-src: add protection against nulls: main/spprintf.c
| From: | Stanislav Malyshev | Date: | Tue, 20 Jan 2015 19:49:23 +0000 |
| Subject: | com php-src: add protection against nulls: main/spprintf.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-84221@lists.php.net to get a copy of this message | ||
Commit: 49af59b3a095ed1a9e61e9183cedaafcf3b5aa7f
Author: Stanislav Malyshev <stas@php.net> Tue, 20 Jan 2015 11:46:10 -0800
Parents: e63f7b47e1937821e75e9862284c3150e1b1d524
Branches: PHP-5.4.37
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=49af59b3a095ed1a9e61e9183cedaafcf3b5aa7f
Log:
add protection against nulls
Changed paths:
M main/spprintf.c
Diff:
diff --git a/main/spprintf.c b/main/spprintf.c
index 5b16d51..01d80b7 100644
--- a/main/spprintf.c
+++ b/main/spprintf.c
@@ -796,6 +796,11 @@ PHPAPI int vspprintf(char **pbuf, size_t max_len, const char *format, va_list
ap
{
smart_str xbuf = {0};
+ /* since there are places where (v)spprintf called without checking for null,
+ a bit of defensive coding here */
+ if(!pbuf) {
+ return 0;
+ }
xbuf_format_converter(&xbuf, format, ap);
if (max_len && xbuf.len > max_len) {