com php-src: Fix the most obvious issues here. There are other problems though: README.EXT_SKEL ext/skeleton/create_stubs
| From: | Rasmus Lerdorf | Date: | Wed, 21 Jan 2015 07:56:51 +0000 |
| Subject: | com php-src: Fix the most obvious issues here. There are other problems though: README.EXT_SKEL ext/skeleton/create_stubs | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-84260@lists.php.net to get a copy of this message | ||
Commit: 41013ba5976446f59bc192fb2c047454550c04c3
Author: Rasmus Lerdorf <rasmus@lerdorf.com> Tue, 20 Jan 2015 23:56:51 -0800
Parents: f9664ce8536d5acb510184adf39b20327ddccb55
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=41013ba5976446f59bc192fb2c047454550c04c3
Log:
Fix the most obvious issues here.
There are other problems though
Changed paths:
M README.EXT_SKEL
M ext/skeleton/create_stubs
Diff:
diff --git a/README.EXT_SKEL b/README.EXT_SKEL
index 42df006..fdf7ad0 100644
--- a/README.EXT_SKEL
+++ b/README.EXT_SKEL
@@ -164,11 +164,11 @@ PHP_FUNCTION(module_name_drawtext)
char *text = NULL;
int argc = ZEND_NUM_ARGS();
int image_id = -1;
- int text_len;
+ size_t text_len;
int font_id = -1;
- long x;
- long y;
- long color;
+ zend_long x;
+ zend_long y;
+ zend_long color;
zval *image = NULL;
zval *font = NULL;
diff --git a/ext/skeleton/create_stubs b/ext/skeleton/create_stubs
index f9f39b1..1163908 100755
--- a/ext/skeleton/create_stubs
+++ b/ext/skeleton/create_stubs
@@ -19,14 +19,14 @@ function convert(i, j, t)
for (i = 0; i < t; i++) { tabs = tabs "\t" }
if (type == "int" || type == "long") {
- longs = longs "\tlong " name ";\n"
+ longs = longs "\tzend_long " name ";\n"
} else if (type == "bool" || type == "boolean") {
bools = bools "\tzend_bool " name ";\n"
} else if (type == "double" || type == "float") {
doubles = doubles "\tdouble " name ";\n"
} else if (type == "string") {
strings = strings "\tchar *" name " = NULL;\n"
- ints = ints "\tint " name "_len;\n"
+ ints = ints "\tsize_t " name "_len;\n"
} else if (type == "array" || type == "object" || type == "mixed") {
zvals = zvals "\tzval *" name " = NULL;\n"
} else if (type == "resource" || type == "handle") {