Re: com php-src: We'd better not include this test script: tests/basic/bug68986.phpt
| From: | Stanislav Malyshev | Date: | Thu, 05 Feb 2015 08:40:14 +0000 |
| Subject: | Re: com php-src: We'd better not include this test script: tests/basic/bug68986.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-84662@lists.php.net to get a copy of this message | ||
Hi!
On 2/5/15 12:27 AM, Xinchen Hui wrote:
> Commit: aa74a529850776f425041e458ab043499a4acec2
> Author: Xinchen Hui <laruence@php.net> Thu, 5 Feb 2015 16:27:01 +0800
> Parents: 22a468dc71bfbf0669c582ab5b8fae764a253246
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=aa74a529850776f425041e458ab043499a4acec2
>
> Log:
> We'd better not include this test script
Why not include the test for the problem? This one has to be fixed, of
course (e.g. see my comments on
https://github.com/php/php-src/pull/1052) but
not having any test is not
good either.
--
Stas Malyshev
smalyshev@gmail.com