Re: cvs: php4 /pear Makefile.in PEAR_ERROR.php

From:	Andi Gutmans	Date:	Sat, 22 Jul 2000 14:50:43 +0000
Subject:	Re: cvs: php4 /pear Makefile.in PEAR_ERROR.php
References:	1 2	Groups:	php.cvs
Request:	Send a blank email to php-cvs+get-860@lists.php.net to get a copy of this message

At 08:26 21/07/2000 -0500, Andrei Zmievski wrote:

On Fri, 21 Jul 2000, Sterling Hughes wrote: class PEAR_ERROR {

      var $CLASSNAME            = '';
      var $ERROR_MESSAGE_PREFIX = '';
      var $ERROR_PREPEND        = '';
      var $ERROR_APPEND         = '';

      var $DIE_ON_ERROR         = '';
      var $AUTO_PRINT_ERROR     = '';

      var $LEVEL         = 0;
      var $TRIGGER_ERROR = false;

Why do we need capitalized class variables?

Yes, it looks too much like constants. I would either do ErrorPrepend or error_prepend.

      function PEAR_ERROR ($message, $file = __FILE__, $line = __LINE__)
Or capitalized class name, for that matter... PEAR_Error would be fine.

Agree too. Andi --- Andi Gutmans <andi@zend.com> http://www.zend.com/