Re: cvs: php4 /main rfc1867.c
| From: | Stefan Esser | Date: | Thu, 13 Dec 2001 18:42:08 +0000 |
| Subject: | Re: cvs: php4 /main rfc1867.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-8609@lists.php.net to get a copy of this message | ||
> Sterling: Thursday, December 13, 2001 7:19 PM
> Please provide a more descriptive note about what you changed and
> what was wrong. Also, it would be great if you could add some
> test cases, which show what the problem was, and how your fixes made
> the problem go away.
Next time i will follow your advise. I did not want to write redundant
comments.
Array uploads did not work because php_register_variable truncates [*] from
the variable name and therefore had to be moved a few lines down. I marked
that as comment in the patch. And one cannot really write test cases for the
bugs
i fixed without writing something that send malformed/untypical POST
headers.
Stefan Esser