com php-src: Fixed bug #68652 (segmentation fault in destructor): NEWS Zend/tests/bug68652.phpt Zend/zend_opcode.c

Commit: 21bb33cc723c0745cd440d74c375b6e86f20a92c Author: Dmitry Stogov <dmitry@zend.com> Mon, 6 Apr 2015 18:11:41 +0300 Parents: 890195f85c08ca3bd246de662bed10331e7b6f79 Branches: PHP-5.5 PHP-5.6 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=21bb33cc723c0745cd440d74c375b6e86f20a92c Log: Fixed bug #68652 (segmentation fault in destructor) Bugs: https://bugs.php.net/68652 Changed paths: M NEWS A Zend/tests/bug68652.phpt M Zend/zend_opcode.c Diff: diff --git a/NEWS b/NEWS index 2bc4f7c..3e5dcce 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,9 @@ PHP NEWS ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||| ?? ??? 2015, PHP 5.5.25 +- Core: + . Fixed bug #68652 (segmentation fault in destructor). (Dmitry) + - cURL: . Fixed bug #68739 (Missing break / control flow). (Laruence) diff --git a/Zend/tests/bug68652.phpt b/Zend/tests/bug68652.phpt new file mode 100644 index 0000000..be65513 --- /dev/null +++ b/Zend/tests/bug68652.phpt @@ -0,0 +1,40 @@ +--TEST-- +Bug #68652 (segmentation fault in destructor) +--FILE-- +<?php +class Foo { + + private static $instance; + public static function getInstance() { + if (isset(self::$instance)) { + return self::$instance; + } + return self::$instance = new self(); + } + + public function __destruct() { + Bar::getInstance(); + } +} + +class Bar { + + private static $instance; + public static function getInstance() { + if (isset(self::$instance)) { + return self::$instance; + } + return self::$instance = new self(); + } + + public function __destruct() { + Foo::getInstance(); + } +} + + +$foo = new Foo(); +?> +--EXPECTF-- +Fatal error: Access to undeclared static property: Bar::$instance in %sbug68652.php on line %d + diff --git a/Zend/zend_opcode.c b/Zend/zend_opcode.c index b8e850d..6c61d1a 100644 --- a/Zend/zend_opcode.c +++ b/Zend/zend_opcode.c @@ -162,16 +162,16 @@ static inline void cleanup_user_class_data(zend_class_entry *ce TSRMLS_DC) zend_hash_apply(&ce->function_table, (apply_func_t) zend_cleanup_function_data_full TSRMLS_CC); } if (ce->static_members_table) { + zval *static_members = ce->static_members_table; + int count = ce->default_static_members_count; int i; - for (i = 0; i < ce->default_static_members_count; i++) { - if (ce->static_members_table[i]) { - zval *p = ce->static_members_table[i]; - ce->static_members_table[i] = NULL; - zval_ptr_dtor(&p); - } + ce->default_static_members_count = 0; + ce->default_static_members_table = ce->static_members_table = NULL; + for (i = 0; i < count; i++) { + zval_ptr_dtor(&static_members[i]); } - ce->static_members_table = NULL; + efree(static_members); } }