com php-src: Rename prefixed mysqlnd functions - prefixed with undescore, which were accessible through a macro. Also removing the access macros.
These prefixed functions were used, similarly to many functions in Zend2, because of TSRMLS - the macro was adding the the tsrm pointer to the call.
However, as in Zend3 no TSRM pointers are passed down the stack, because of the usage of cached TSRM pointer in a real thread local variable, these
macros

Commit: 871ff65fd161eb9f96577ae0a35599075eabc7cc Author: Andrey Hristov <andrey@php.net> Tue, 7 Apr 2015 21:48:08 +0200 Parents: ed0f134a642e7caed94966450435ed5e2a21f426 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=871ff65fd161eb9f96577ae0a35599075eabc7cc Log: Rename prefixed mysqlnd functions - prefixed with undescore, which were accessible through a macro. Also removing the access macros. These prefixed functions were used, similarly to many functions in Zend2, because of TSRMLS - the macro was adding the the tsrm pointer to the call. However, as in Zend3 no TSRM pointers are passed down the stack, because of the usage of cached TSRM pointer in a real thread local variable, these macros and prefixed naming have lost their purpose. Changed paths: M ext/mysqlnd/mysqlnd.c M ext/mysqlnd/mysqlnd.h M ext/mysqlnd/mysqlnd_debug.c M ext/mysqlnd/mysqlnd_plugin..c Diff: diff --git a/ext/mysqlnd/mysqlnd.c b/ext/mysqlnd/mysqlnd..c index 37794cc..227c420 100644 --- a/ext/mysqlnd/mysqlnd.c +++ b/ext/mysqlnd/mysqlnd.c @@ -1363,9 +1363,9 @@ static int mysqlnd_stream_array_from_fd_set(MYSQLND ** conn_array, fd_set * fds) #endif -/* {{{ _mysqlnd_poll */ +/* {{{ mysqlnd_poll */ PHPAPI enum_func_status -_mysqlnd_poll(MYSQLND **r_array, MYSQLND **e_array, MYSQLND ***dont_poll, long sec, long usec, int * desc_num) +mysqlnd_poll(MYSQLND **r_array, MYSQLND **e_array, MYSQLND ***dont_poll, long sec, long usec, int * desc_num) { struct timeval tv; struct timeval *tv_p = NULL; @@ -3139,9 +3139,9 @@ MYSQLND_CLASS_METHODS_START(mysqlnd_conn) MYSQLND_CLASS_METHODS_END; -/* {{{ _mysqlnd_init */ +/* {{{ mysqlnd_init */ PHPAPI MYSQLND * -_mysqlnd_init(unsigned int flags, zend_bool persistent) +mysqlnd_init(unsigned int flags, zend_bool persistent) { MYSQLND * ret; DBG_ENTER("mysqlnd_init"); diff --git a/ext/mysqlnd/mysqlnd.h b/ext/mysqlnd/mysqlnd.h index bbd0e82..eded4a1 100644 --- a/ext/mysqlnd/mysqlnd.h +++ b/ext/mysqlnd/mysqlnd.h @@ -69,11 +69,9 @@ PHPAPI void mysqlnd_library_end(void); PHPAPI unsigned int mysqlnd_plugin_register(); PHPAPI unsigned int mysqlnd_plugin_register_ex(struct st_mysqlnd_plugin_header * plugin); PHPAPI unsigned int mysqlnd_plugin_count(); -PHPAPI void * _mysqlnd_plugin_find(const char * const name); -#define mysqlnd_plugin_find(name) _mysqlnd_plugin_find((name)); +PHPAPI void * mysqlnd_plugin_find(const char * const name); -PHPAPI void _mysqlnd_plugin_apply_with_argument(apply_func_arg_t apply_func, void * argument); -#define mysqlnd_plugin_apply_with_argument(func, argument) _mysqlnd_plugin_apply_with_argument((func), (argument)); +PHPAPI void mysqlnd_plugin_apply_with_argument(apply_func_arg_t apply_func, void * argument); #define mysqlnd_restart_psession(conn) ((conn)->data)->m->restart_psession((conn)->data) #define mysqlnd_end_psession(conn) ((conn)->data)->m->end_psession((conn)->data) @@ -85,8 +83,7 @@ PHPAPI const MYSQLND_CHARSET * mysqlnd_find_charset_name(const char * const char /* Connect */ -#define mysqlnd_init(client_flags, persistent) _mysqlnd_init((client_flags), (persistent)) -PHPAPI MYSQLND * _mysqlnd_init(unsigned int client_flags, zend_bool persistent); +PHPAPI MYSQLND * mysqlnd_init(unsigned int client_flags, zend_bool persistent); PHPAPI MYSQLND * mysqlnd_connect(MYSQLND * conn, const char * host, const char * user, const char * passwd, unsigned int passwd_len, @@ -100,8 +97,7 @@ PHPAPI MYSQLND * mysqlnd_connect(MYSQLND * conn, #define mysqlnd_change_user(conn, user, passwd, db, silent) ((conn)->data)->m->change_user((conn)->data, (user), (passwd), (db), (silent), strlen((passwd))) #define mysqlnd_change_user_ex(conn, user, passwd, db, silent, passwd_len) ((conn)->data)->m->change_user((conn)->data, (user), (passwd), (db), (silent), (passwd_len)) -#define mysqlnd_debug(x) _mysqlnd_debug((x)) -PHPAPI void _mysqlnd_debug(const char *mode); +PHPAPI void mysqlnd_debug(const char *mode); /* Query */ #define mysqlnd_fetch_into(result, flags, ret_val, ext) (result)->m.fetch_into((result), (flags), (ret_val), (ext) ZEND_FILE_LINE_CC) @@ -114,11 +110,10 @@ PHPAPI void _mysqlnd_debug(const char *mode); #define mysqlnd_close(conn,is_forced) (conn)->m->close((conn), (is_forced)) #define mysqlnd_query(conn, query_str, query_len) ((conn)->data)->m->query((conn)->data, (query_str), (query_len)) #define mysqlnd_async_query(conn, query_str, query_len) ((conn)->data)->m->send_query((conn)->data, (query_str), (query_len), MYSQLND_SEND_QUERY_EXPLICIT, NULL, NULL) -#define mysqlnd_poll(r, err, d_pull,sec,usec,desc_num) _mysqlnd_poll((r), (err), (d_pull), (sec), (usec), (desc_num)) #define mysqlnd_reap_async_query(conn) ((conn)->data)->m->reap_query((conn)->data, MYSQLND_REAP_RESULT_EXPLICIT) #define mysqlnd_unbuffered_skip_result(result) (result)->m.skip_result((result)) -PHPAPI enum_func_status _mysqlnd_poll(MYSQLND **r_array, MYSQLND **e_array, MYSQLND ***dont_poll, long sec, long usec, int * desc_num); +PHPAPI enum_func_status mysqlnd_poll(MYSQLND **r_array, MYSQLND **e_array, MYSQLND ***dont_poll, long sec, long usec, int * desc_num); #define mysqlnd_use_result(conn) ((conn)->data)->m->use_result((conn)->data, 0) #define mysqlnd_store_result(conn) ((conn)->data)->m->store_result((conn)->data, MYSQLND_STORE_NO_COPY) diff --git a/ext/mysqlnd/mysqlnd_debug.c b/ext/mysqlnd/mysqlnd_debug.c index 96f78ba..812963a 100644 --- a/ext/mysqlnd/mysqlnd_debug.c +++ b/ext/mysqlnd/mysqlnd_debug.c @@ -723,8 +723,8 @@ mysqlnd_debug_init(const char * skip_functions[]) /* }}} */ -/* {{{ _mysqlnd_debug */ -PHPAPI void _mysqlnd_debug(const char * mode) +/* {{{ mysqlnd_debug */ +PHPAPI void mysqlnd_debug(const char * mode) { #if PHP_DEBUG MYSQLND_DEBUG * dbg = MYSQLND_G(dbg); diff --git a/ext/mysqlnd/mysqlnd_plugin.c b/ext/mysqlnd/mysqlnd_plugin.c index d070928..094bd55 100644 --- a/ext/mysqlnd/mysqlnd_plugin.c +++ b/ext/mysqlnd/mysqlnd_plugin.c @@ -153,20 +153,19 @@ PHPAPI unsigned int mysqlnd_plugin_register_ex(struct st_mysqlnd_plugin_header * /* {{{ mysqlnd_plugin_find */ -PHPAPI void * _mysqlnd_plugin_find(const char * const name) +PHPAPI void * mysqlnd_plugin_find(const char * const name) { void * plugin; if ((plugin = zend_hash_str_find_ptr(&mysqlnd_registered_plugins, name, strlen(name))) != NULL) { return plugin; } return NULL; - } /* }}} */ -/* {{{ _mysqlnd_plugin_apply_with_argument */ -PHPAPI void _mysqlnd_plugin_apply_with_argument(apply_func_arg_t apply_func, void * argument) +/* {{{ mysqlnd_plugin_apply_with_argument */ +PHPAPI void mysqlnd_plugin_apply_with_argument(apply_func_arg_t apply_func, void * argument) { zval *val; int result;