Re: com php-src: Merge branch 'PHP-5.6': ext/standard/mail.c

Hi Xinchen char *force_extra_parameters = INI_STR("mail.force_extra_parameters"); char *to_r, *subject_r; char *p, *e; - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sss|ss", &to, &to_len, &subject, &subject_len, &message, &message_len, &headers, &headers_len, &extra_cmd, &extra_cmd_len ) == FAILURE) { + if (zend_parse_parameters(ZEND_NUM_ARGS() , "sss|SS", &to, &to_len, &subject, &subject_len, &message, &message_len, &headers, &extra_cmd ) == FAILURE) { return; } This would be nicer, if this is + if (zend_parse_parameters(ZEND_NUM_ARGS() , "SSS|SS", &to, &subject, &message, &headers, &extra_cmd) == FAILURE) { We are better to avoid gradual zend_string adoption as much as possible. IMO. There are too many codes like this, though. Regards. -- Yasuo Ohgaki yohgaki@ohgaki.net On Fri, Jun 19, 2015 at 10:36 AM, Xinchen Hui <laruence@php.net> wrote: > Commit: 29087f00f6be121a46135ac7f2b014cc5c082c66 > Author: Xinchen Hui <laruence@php.net> Fri, 19 Jun 2015 > 09:36:27 +0800 > Parents: cdde1be056b21ae6bee51a9c22711c22cede568b > bca005c8d9fa047e2d4b0f2496f771f4a74f458d > Branches: master > > Link: > > http://git.php.net/?p=php-src.git;a=commitdiff;h=29087f00f6be121a46135ac7f2b014cc5c082c66 > > Log: > Merge branch 'PHP-5.6' > > Changed paths: > MM ext/standard/mail.c > > > Diff: > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >