Re: cvs: php4 /ext/standard file.c

> At 04:09 AM 12/21/01 +0100, Sterling Hughes wrote: > >> elixer Thu Dec 20 22:10:12 2001 EDT > >> > >> Modified files: > >> /php4/ext/standard file.c > >> Log: > >> Initialize variable to avoid bogus data and possible segfault. > >> > > The patch seems bad -- you don't want to initialize a structure like > > that as it is *way* too dependent on field ordering. > > Umm, then initializing PHP function entry tables is bogus too? > A couple of differences: a) its pretty static (the structure probably won't ever change). b) it would be a bitch to do it another way c) macro's are used to abstract the process d) it's not used for something as trivial as zero'ing out a structure. e) Its really not as widely used as a function_entry so, yeah, in a strict manner I'd say its not the best idea to initialize a function table the way we do, however, because of the implementation details -- it becomes the only sensible way to do it. Here I don't think that is the case. -Sterling > -Andrei >