RE: [PHP-CVS] com php-src: fix negative zend_long to size_t cast: ext/standard/string.c
| From: | ab@php.net | Date: | Mon, 29 Jun 2015 09:23:24 +0000 |
| Subject: | RE: [PHP-CVS] com php-src: fix negative zend_long to size_t cast: ext/standard/string.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-87613@lists.php.net to get a copy of this message | ||
Hi Yasuo,
> -----Original Message-----
> From: yohgaki@gmail.com [mailto:yohgaki@gmail.com] On Behalf Of Yasuo
> Ohgaki
> Sent: Monday, June 29, 2015 10:41 AM
> To: Anatol Belski
> Cc: php-cvs@lists.php.net
> Subject: Re: [PHP-CVS] com php-src: fix negative zend_long to size_t cast:
> ext/standard/string.c
>
> Hi Anatol,
>
> On Mon, Jun 29, 2015 at 5:27 PM, Anatol Belski <ab@php.net> wrote:
>
> > + if (f < 0 && -f > Z_STRLEN_P(str)) {
>
>
> It seems this could be
>
> + if (-f > Z_STRLEN_P(str)) {
>
Ahh, you're right, f < 0 is checked in the line above. I need more coffee :) But there are
actually a couple of more cases about this, working on them yet.
Thanks
Anatol