com php-src: Better fix for bug #69958: ext/phar/phar_object .c
| From: | Stanislav Malyshev | Date: | Tue, 07 Jul 2015 17:17:54 +0000 |
| Subject: | com php-src: Better fix for bug #69958: ext/phar/phar_object .c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-87821@lists.php.net to get a copy of this message | ||
Commit: 3bee16a70ab38cebad36d6276dafaef40715cfe8
Author: Stanislav Malyshev <stas@php.net> Mon, 6 Jul 2015 22:58:28 -0700
Parents: d8aa5675ad2ead0469c15fad167ecbdd60051716
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=3bee16a70ab38cebad36d6276dafaef40715cfe8
Log:
Better fix for bug #69958
Bugs:
https://bugs.php.net/69958
Changed paths:
M ext/phar/phar_object.c
Diff:
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
index ebb15f0..dd65a08 100644
--- a/ext/phar/phar_object.c
+++ b/ext/phar/phar_object.c
@@ -1996,9 +1996,10 @@ static int phar_copy_file_contents(phar_entry_info *entry, php_stream *fp) /*
{{
}
/* }}} */
-static zend_object *phar_rename_archive(phar_archive_data *phar, char *ext, zend_bool compress) /*
{{{ */
+static zend_object *phar_rename_archive(phar_archive_data **sphar, char *ext, zend_bool compress)
/* {{{ */
{
const char *oldname = NULL;
+ phar_archive_data *phar = *sphar;
char *oldpath = NULL;
char *basename = NULL, *basepath = NULL;
char *newname = NULL, *newpath = NULL;
@@ -2108,6 +2109,7 @@ static zend_object *phar_rename_archive(phar_archive_data *phar, char *ext,
zend
pphar->fp = phar->fp;
phar->fp = NULL;
phar_destroy_phar_data(phar);
+ *sphar = NULL;
phar = pphar;
phar->refcount++;
newpath = oldpath;
@@ -2290,17 +2292,19 @@ no_copy:
phar_add_virtual_dirs(phar, newentry.filename, newentry.filename_len);
} ZEND_HASH_FOREACH_END();
- if ((ret = phar_rename_archive(phar, ext, 0))) {
+ if ((ret = phar_rename_archive(&phar, ext, 0))) {
return ret;
} else {
- zend_hash_destroy(&(phar->manifest));
- zend_hash_destroy(&(phar->mounted_dirs));
- zend_hash_destroy(&(phar->virtual_dirs));
- if (phar->fp) {
- php_stream_close(phar->fp);
+ if(phar != NULL) {
+ zend_hash_destroy(&(phar->manifest));
+ zend_hash_destroy(&(phar->mounted_dirs));
+ zend_hash_destroy(&(phar->virtual_dirs));
+ if (phar->fp) {
+ php_stream_close(phar->fp);
+ }
+ efree(phar->fname);
+ efree(phar);
}
- efree(phar->fname);
- efree(phar);
return NULL;
}
}