com php-src: Add comment to explaining the new check: ext/opcache/Optimizer/optimize_temp_vars_5.c
| From: | Xinchen Hui | Date: | Wed, 08 Jul 2015 09:44:54 +0000 |
| Subject: | com php-src: Add comment to explaining the new check: ext/opcache/Optimizer/optimize_temp_vars_5.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-87843@lists.php.net to get a copy of this message | ||
Commit: 249915f938f6880b68ab6c6a47952c509dc51604
Author: Xinchen Hui <laruence@php.net> Wed, 8 Jul 2015 17:44:54 +0800
Parents: 3b5876916dca1ce1db7533a0848b7f912101e07b
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=249915f938f6880b68ab6c6a47952c509dc51604
Log:
Add comment to explaining the new check
Changed paths:
M ext/opcache/Optimizer/optimize_temp_vars_5.c
Diff:
diff --git a/ext/opcache/Optimizer/optimize_temp_vars_5.c
b/ext/opcache/Optimizer/optimize_temp_vars_5.c
index de170d2..f60f61c 100644
--- a/ext/opcache/Optimizer/optimize_temp_vars_5.c
+++ b/ext/opcache/Optimizer/optimize_temp_vars_5.c
@@ -152,6 +152,9 @@ void optimize_temporary_variables(zend_op_array *op_array, zend_optimizer_ctx *c
currT = VAR_NUM(ZEND_RESULT(opline).var) - offset;
if (valid_T[currT]) {
if (start_of_T[currT] == opline) {
+ /* ZEND_FAST_CALL can not share temporary var with others
+ * since the fast_var could also be set by ZEND_HANDLE_EXCEPTION
+ * which could be ahead of it */
if (opline->opcode != ZEND_FAST_CALL) {
taken_T[map_T[currT]] = 0;
}