com php-src: Fix #70289: Different sort in php7 (and hhvm) compared to php5: UPGRADING UPGRADING.INTERNALS

Commit: 1b5e87a579080da1452e173981b7d8a6814f15c0 Author: Christoph M. Becker <cmb@php.net> Tue, 18 Aug 2015 13:44:14 +0200 Parents: 22eaa995ee62ba6332a82d4754a179b6be847fe9 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=1b5e87a579080da1452e173981b7d8a6814f15c0 Log: Fix #70289: Different sort in php7 (and hhvm) compared to php5 We add a respective note to UPGRADING. Furthermore, as renaming of zend_qsort() and the new zend_insert_sort() are irrelevant for user-land, we move this info to UPGRADING.INTERNALS. Bugs: https://bugs.php.net/70289 Changed paths: M UPGRADING M UPGRADING.INTERNALS Diff: diff --git a/UPGRADING b/UPGRADING index 2df744e..f84fa0a 100644 --- a/UPGRADING +++ b/UPGRADING @@ -431,9 +431,8 @@ Standard library changes . call_user_method() and call_user_method_array() no longer exists. . ob_start() no longer issues an E_ERROR, but instead an E_RECOVERABLE_ERROR in case an output buffer is created in an output buffer handler. - . Improved zend_qsort(using hybrid sorting algo) for better performance, - and also renamed zend_qsort to zend_sort. - . Added stable sorting algo zend_insert_sort. + . The internal sorting algorithm has been improved, what may result in + different sort order of elements that compare as equal. . Removed dl() function on fpm-fcgi. . setcookie() with an empty cookie name now issues a WARNING and doesn't send an empty set-cookie header line anymore. diff --git a/UPGRADING.INTERNALS b/UPGRADING.INTERNALS index d5921ec..384b71b 100644 --- a/UPGRADING.INTERNALS +++ b/UPGRADING.INTERNALS @@ -19,6 +19,7 @@ PHP 7.0 INTERNALS UPGRADE NOTES s. Resource API changes t. Optimized strings concatenation. u. Streams changes + v. Sort algorithm changes 2. Build system changes a. Unix build system changes @@ -240,6 +241,11 @@ changes. See: https://wiki.php.net/phpng-upgrading using context stream option PHP_STREAM_OPTION_PIPE_BLOCKING or adding STREAM_USE_BLOCKING_PIPE when opening the stream. + v. Sort algorithm changes + - Improved zend_qsort(using hybrid sorting algo) for better performance, + and also renamed zend_qsort to zend_sort. + - Added stable sorting algo zend_insert_sort. + ======================== 2. Build system changes ========================