Re: cvs: php4 /ext/standard basic_functions.c

On Sun, Dec 30, 2001 at 01:20:01PM -0700, Zak Greant wrote: > > > - if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &str) == > > > FAILURE) { - WRONG_PARAM_COUNT; > > > - } > > > - convert_to_string_ex(str); > > > - > > > - if (Z_TYPE_PP(str) != IS_STRING) { > > > + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &str, > > > &str_len) == FAILURE) { RETURN_FALSE; > > > } > > > > Shouldn't this still return WRONG_PARAM_COUNT on failure? > > Nope - but thanks for checking up on me! These are my first few > sets of real changes and I am nervous as hell! :) Ah, okay, I re-read README.PARAMETER_PARSING_API and have it all straight now. Time to correct some of my own local code. =) -- Jon Parise (jon@csh.rit.edu) . Information Technology (2001) http://www.csh.rit.edu/~jon/ : Computer Science House Member