Re: cvs: php4 /ext/dbplus php_dbplus.c
| From: | Egon Schmid | Date: | Mon, 31 Dec 2001 09:10:34 +0000 |
| Subject: | Re: cvs: php4 /ext/dbplus php_dbplus.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-8877@lists.php.net to get a copy of this message | ||
From: "Zak Greant" <zak@php.net>
> On 2001-30-12 00:29, Egon Schmid wrote:
> > eschmid Sun Dec 30 02:29:11 2001 EDT
> >
> > Modified files:
> > /php4/ext/dbplus php_dbplus.c
> > Log:
> > Fixed some protos.
> Do we need to make changes like this? I feel that changing the
tense
> of a proto message, when the original tense is not wrong, is a
not an
> effective use of time.
If you look deep into the diff, you will see some changes in the
indentation for the proto message. Then compare version 1.13 and
1.12 of funcsummary.txt. If the proto message in the source code
isn´t excatly 3 spaces funcsummary looks very ugly. The original
tense is not wrong and when I look for protos I have to read all
protos and corrects them.
-Egon