Re: com php-src: remove unnecessary check: ext/opcache/zend_persist_calc.c

why to remove? It was especially introduced to catch incorrectly aligned data. Incorrect alignment causes penalty on each read/write of 64-bit value slitted across 2 cache lines. Thanks. Dmitry. On Mon, Sep 7, 2015 at 4:14 PM, Anatol Belski <ab@php.net> wrote: > Commit: 46792a9914cf0ab04cba01b9162c4954efafccc4 > Author: Anatol Belski <ab@php.net> Mon, 7 Sep 2015 15:14:26 > +0200 > Parents: eaf96698c7e3229b0217ca3a408fb3b50b9bd333 > Branches: master > > Link: > > http://git.php.net/?p=php-src.git;a=commitdiff;h=46792a9914cf0ab04cba01b9162c4954efafccc4 > > Log: > remove unnecessary check > > as it's unrelated to the size pre calculation > > Changed paths: > M ext/opcache/zend_persist_calc.c > > > Diff: > diff --git a/ext/opcache/zend_persist_calc.c > b/ext/opcache/zend_persist_calc.c > index 3b8356a..d07e309 100644 > --- a/ext/opcache/zend_persist_calc.c > +++ b/ext/opcache/zend_persist_calc.c > @@ -71,7 +71,6 @@ static void zend_hash_persist_calc(HashTable *ht, void > (*pPersistElement)(zval * > } > } > ADD_SIZE(hash_size * sizeof(uint32_t) + ht->nNumUsed * > sizeof(Bucket)); > - ZEND_ASSERT(((zend_uintptr_t)ZCG(mem) & 0x7) == 0); /* > should be 8 byte aligned */ > } else { > ADD_SIZE(HT_USED_SIZE(ht)); > } > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >