Re: com php-src: Added support of LDAP_OPT_TIMEOUT, fixes #69574: ext/ldap/ldap.c ext/ldap/tests/ldap_get_option_variation.phpt
| From: | Ferenc Kovacs | Date: | Thu, 10 Sep 2015 11:29:02 +0000 |
| Subject: | Re: com php-src: Added support of LDAP_OPT_TIMEOUT, fixes #69574: ext/ldap/ldap.c ext/ldap/tests/ldap_get_option_variation.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-88990@lists.php.net to get a copy of this message | ||
On Thu, Sep 10, 2015 at 12:04 PM, Kalle Sommer Nielsen <kalle@php.net>
wrote:
> Hi Côme
>
> 2015-09-09 18:02 GMT+02:00 Côme Bernigaud <mcmic@php.net>:
> > Commit: 059dd18c37d7814da4d496be0c9ab75121536c4b
> > Author: Côme Bernigaud <mcmic@php.net> Wed, 9 Sep 2015
> 18:02:10 +0200
> > Parents: 43f6099ce41c0f022e5fae4876927592568c94ed
> > Branches: PHP-5.6
> >
> > Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=059dd18c37d7814da4d496be0c9ab75121536c4b
> >
> > Log:
> > Added support of LDAP_OPT_TIMEOUT, fixes #69574
>
> Was this OK'ed by Ferenc for 5.6? Also I did not see anything about
> this on the ML before it was committed to master, remember we're in RC
> so its thin what we can continue to put into it.
>
>
I think it is a useful addition but the standard procedure is to ping the
internals mailing list first, and if there are no clear consensus the safe
road to take is to have an RFC (for example
the JSON_PRESERVE_FRACTIONAL_PART flag was added in a micro version via an
RFC: https://wiki.php.net/rfc/json_preserve_fractional_part
).
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu