Re: com php-src: Fix #70013: Reference to $_SESSION is lost after a call to session_regenerate_id(): ext/session/session.c
ext/session/tests/bug67694.phpt ext/session/tests/bug70013.phpt

From: Date: Wed, 16 Sep 2015 12:33:41 +0000
Subject: Re: com php-src: Fix #70013: Reference to $_SESSION is lost after a call to session_regenerate_id(): ext/session/session.c
ext/session/tests/bug67694.phpt ext/session/tests/bug70013.phpt
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-89043@lists.php.net to get a copy of this message
Hi Remi, On Wed, Sep 16, 2015 at 8:25 PM, Remi Collet <remi@fedoraproject.org> wrote: > Le 16/09/2015 13:06, Remi Collet a écrit : >> Le 06/09/2015 20:57, Yasuo Ohgaki a écrit : >>> Commit: f34b858ed018d4c33bc0c3f03acc0bf143d35534 Author: Yasuo >>> Ohgaki <yohgaki@php.net> Sun, 6 Sep 2015 17:14:34 +0900 >>> Parents: 22e23e7cb8ca9aa134d138b5fed031af6c842b44 Branches: >>> master >> >>> Link: >>> >>> http://git.php.net/?p=php-src.git;a=commitdiff;h=f34b858ed018d4c33bc0 > c >> >>> > 3f03acc0bf143d35534 >> >> I >> >> think session management is broken (regression between RC2 and >> RC2) >> >> I an app call "regenerate_session_id()" and the fill the $_SESSION >> On the next page, the $_SESSION is empty. >> >> This seems critical >> >> >> Remi. >> >> > > > Reproducer: > > <pre> > <?php > session_start(); > echo "Received:\n"; > print_r($_SESSION); > session_unset(); > session_regenerate_id(); > //session_start(); > $_SESSION['valid_id'] = session_id(); > echo "Saved:\n"; > print_r($_SESSION); > > > With PHP 5.x / 7.0.0RC2, > on second call "received" == "saved" content from previous call > > With 7.0.0RC3, "received" is empty. Thank you. Verified. It seems php_session_reset_id() does not send cookie or does something wrong. I'll fix it. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net

« previous php.cvs (#89043) next »