Re: com php-src: Fixed bug #70630 (Closure::call/bind() crash with ReflectionFunction->getClosure()) This additionally removes support for binding to
an unknown (not in parent hierarchy) scope. Removing support for cross-scope is necessary for certain compile-time assumptions (like class constants)
to prevent unexpected results: NEWS Zend/tests/bug70630.phpt Zend/tests/closure_061.phpt Zend/zend_closures.c Zend/zend_compile.c Zend/zend_compile.h
| From: | Dmitry Stogov | Date: | Mon, 05 Oct 2015 07:54:57 +0000 |
| Subject: | Re: com php-src: Fixed bug #70630 (Closure::call/bind() crash with ReflectionFunction->getClosure()) This additionally removes support for binding to an unknown (not in parent hierarchy) scope. Removing support for cross-scope is necessary for certain compile-time assumptions (like class constants) to prevent unexpected results: NEWS Zend/tests/bug70630.phpt Zend/tests/closure_061.phpt Zend/zend_closures.c Zend/zend_compile.c Zend/zend_compile.h |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-89290@lists.php.net to get a copy of this message | ||
Hi Andrea,
Could you please verify that these patches don't break the intended
behavior proposed in corresponding RFC.
I'm especially not sure about removing check for ZEND_ACC_STATIC in
Closure::call().
http://git.php.net/?p=php-src.git;a=commitdiff;h=517b5536259ecf7697f353f4bfbafde857fc1f81
http://git.php.net/?p=php-src.git;a=commitdiff;h=881c50252066132f83e190325e344f532be19033
Thanks. Dmitry.
On Sun, Oct 4, 2015 at 2:38 AM, Bob Weinand <bwoebi@php.net> wrote:
> Commit: 517b5536259ecf7697f353f4bfbafde857fc1f81
> Author: Bob Weinand <bobwei9@hotmail.com> Sun, 4 Oct 2015
> 01:38:59 +0200
> Parents: 4cb6342426aad20d8f92042855499bd4ea4d834c
> Branches: PHP-7.0
>
> Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=517b5536259ecf7697f353f4bfbafde857fc1f81
>
> Log:
> Fixed bug #70630 (Closure::call/bind() crash with
> ReflectionFunction->getClosure())
> This additionally removes support for binding to an unknown (not in parent
> hierarchy) scope.
> Removing support for cross-scope is necessary for certain compile-time
> assumptions (like class constants) to prevent unexpected results
>
> Bugs:
> https://bugs.php.net/70630
>
> Changed paths:
> M NEWS
> A Zend/tests/bug70630.phpt
> A Zend/tests/closure_061.phpt
> M Zend/zend_closures.c
> M Zend/zend_compile.c
> M Zend/zend_compile.h
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>