Re: com php-src: fix coverage report for datelib: ext/date/lib/parse_date.c ext/date/lib/parse_iso_intervals.c
| From: | Derick Rethans | Date: | Mon, 05 Oct 2015 19:13:20 +0000 |
| Subject: | Re: com php-src: fix coverage report for datelib: ext/date/lib/parse_date.c ext/date/lib/parse_iso_intervals.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-89296@lists.php.net to get a copy of this message | ||
On Sun, 4 Oct 2015, Ferenc Kovacs wrote:
> 2015. okt. 4. 11:37 ezt Ãrta ("Nuno Lopes" <nlopess@php.net>):
> >
> > Commit: 67090064578946a0230511516424afbbec5b6cb5
> > Author: Nuno Lopes <nlopess@php.net> Sun, 4 Oct 2015 05:36:47 -0400
> > Parents: 050ce295a49ee6df23d03d73582b2d360129af25
> > Branches: master
> >
> > Link:
> > http://git.php.net/?p=php-src.git;a=commitdiff;h=67090064578946a0230511516424afbbec5b6cb5
> >
> > Log:
> > fix coverage report for datelib
> >
> > Changed paths:
> > M ext/date/lib/parse_date.c
> > M ext/date/lib/parse_iso_intervals.c
>
> Afair Derick keeps this synced from -9¬_ËácF.ÿª
> ¿—Ôhttps://github.com/derickr/timelib
> so with the next update these changes will be lost.
Yes - and as this has only been done in master, I'll get some nice merge
conflicts too :-/ I'd be better if it got reverted.
> Derick how should we proceed with fixes like this which affects
> timelib but ext/date specific?
I think PHP shouldn't test/care about code coverage for timelib.
Instead, this should be added to timelib itself. I have a whole bunch of
test cases, but nothing set-up in Travis yet. I'd be more than happy to
see it added.
cheers,
Derick