Re: com php-src: Add support for IPV6_V6ONLY on sockets: NEWS ext/sockets/sockets.c main/network.c main/php_network.h main/streams/xp_socket.c

From: Date: Fri, 06 Nov 2015 22:39:25 +0000
Subject: Re: com php-src: Add support for IPV6_V6ONLY on sockets: NEWS ext/sockets/sockets.c main/network.c main/php_network.h main/streams/xp_socket.c
References: 1 2  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-89623@lists.php.net to get a copy of this message
> Am 06.11.2015 um 23:34 schrieb Kalle Sommer Nielsen <kalle@php.net>: > > Hi Bob > > 2015-11-06 21:45 GMT+01:00 Bob Weinand <bwoebi@php.net>: >> Commit: 855bb36fd0bad9ac99a176d75a2792e9a1ed23a3 >> Author: Bob Weinand <bobwei9@hotmail.com> Fri, 6 Nov 2015 21:41:51 +0100 >> Parents: 049325ca9662e1d5e6fb2fdc7006b9a68385d9f9 >> Branches: PHP-7.0 >> >> Link: >> http://git.php.net/?p=php-src.git;a=commitdiff;h=855bb36fd0bad9ac99a176d75a2792e9a1ed23a3 >> >> Log: >> Add support for IPV6_V6ONLY on sockets > > We are in feature freeze, and just one week away from the grand > release of 7.0.0, it is way too late to add small, although self > contained features like this, even more without any test cases to it. > I spoke with Anatol about this and we both would like for you to > revert this for the PHP-7.0 branch and wait for after the release. > > Since the feature itself is rather small, we can add it to 7.0.1, but > again, it is too late to have in 7.0.0. Please, if possible add a test > case associated to the commit once you merge it back into PHP-7.0. > > > Thanks Hey Kalle, as far as I saw, the NEWS file is for 7.0.1, so I assumed this will go as a self-contained feature into 7.0.1. Sorry if I mistook something here; if this is the case, I'll revert and re-apply later. Bob

« previous php.cvs (#89623) next »