Re: com php-src: constify parameters: ext/mysqlnd/mysqlnd_ext_plugin.c ext/mysqlnd/mysqlnd_ext_plugin.h ext/mysqlnd/mysqlnd_protocol_frame_codec.c
ext/mysqlnd/mysqlnd_protocol_frame_codec.h
| From: | Dmitry Stogov | Date: | Tue, 17 Nov 2015 15:23:37 +0000 |
| Subject: | Re: com php-src: constify parameters: ext/mysqlnd/mysqlnd_ext_plugin.c ext/mysqlnd/mysqlnd_ext_plugin.h ext/mysqlnd/mysqlnd_protocol_frame_codec.c ext/mysqlnd/mysqlnd_protocol_frame_codec.h |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-89886@lists.php.net to get a copy of this message | ||
Andrey,
please let me know, if you are going to fix this in short time, or I'll
revert your last two commits.
Thanks. Dmitry.
On Tue, Nov 17, 2015 at 6:13 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> You broke the build.
>
> ext/mysqlnd/mysqlnd_protocol_frame_codec.c:99:29: error: assignment of
> read-only location ‘*uncompressed_payload’
> ext/mysqlnd/mysqlnd_protocol_frame_codec.c:99:85: error: assignment of
> read-only location ‘*(uncompressed_payload + 1u)’
> ext/mysqlnd/mysqlnd_protocol_frame_codec.c:99:158: error: assignment of
> read-only location ‘*(uncompressed_payload + 2u)’
> ext/mysqlnd/mysqlnd_protocol_frame_codec.c:145:10: error: assignment of
> read-only location ‘*p’
> ext/mysqlnd/mysqlnd_protocol_frame_codec.c:145:47: error: assignment of
> read-only location ‘*(p + 1u)’
> ext/mysqlnd/mysqlnd_protocol_frame_codec.c:145:101: error: assignment of
> read-only location ‘*(p + 2u)’
>
> Linux, 32-bit, non-ZTS, GCC-5.1.1
>
> Thanks. Dmitry.
>
>
> On Tue, Nov 17, 2015 at 4:49 PM, Andrey Hristov <andrey@php.net> wrote:
>
>> Commit: 4ee4a4bb52b6c6d59a72df9a9379c1ac80a8ab64
>> Author: Andrey Hristov <andrey@php.net> Tue, 17 Nov 2015
>> 14:49:18 +0100
>> Parents: 43bfbd86d9ff726acddcee2aa3f4a54acc0a6a45
>> Branches: master
>>
>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=4ee4a4bb52b6c6d59a72df9a9379c1ac80a8ab64
>>
>> Log:
>> constify parameters
>>
>> Changed paths:
>> M ext/mysqlnd/mysqlnd_ext_plugin.c
>> M ext/mysqlnd/mysqlnd_ext_plugin.h
>> M ext/mysqlnd/mysqlnd_protocol_frame_codec.c
>> M ext/mysqlnd/mysqlnd_protocol_frame_codec.h
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>