com php-src: Fixed bug #70914 zend_throw_or_error() format string vulnerability: Zend/tests/bug709 14.phpt Zend/zend_execute_API.c
| From: | Anatol Belski | Date: | Tue, 17 Nov 2015 12:17:00 +0000 |
| Subject: | com php-src: Fixed bug #70914 zend_throw_or_error() format string vulnerability: Zend/tests/bug709 14.phpt Zend/zend_execute_API.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-89919@lists.php.net to get a copy of this message | ||
Commit: 327b8bf79c5762101ac99930129e2b3e13157c60
Author: Taoguang Chen <taoguangchen@icloud.com> Sat, 14 Nov 2015 23:44:59 +0100
Committer: Anatol Belski <ab@php.net> Tue, 17 Nov 2015 13:17:00 +0100
Parents: 2aa400a0ffba12a551015e329ab53829d25b3805
Branches: PHP-7.0.0
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=327b8bf79c5762101ac99930129e2b3e13157c60
Log:
Fixed bug #70914 zend_throw_or_error() format string vulnerability
Bugs:
https://bugs.php.net/70914
Changed paths:
A Zend/tests/bug70914.phpt
M Zend/zend_execute_API.c
Diff:
diff --git a/Zend/tests/bug70914.phpt b/Zend/tests/bug70914.phpt
new file mode 100644
index 0000000..7da64d7
--- /dev/null
+++ b/Zend/tests/bug70914.phpt
@@ -0,0 +1,17 @@
+--TEST--
+Bug #70895 null ptr deref and segfault with crafted callable
+--SKIPIF--
+<?php
+if (!extension_loaded("pdo_sqlite")) {
+ die("skip pdo_sqlite required");
+}
+?>
+--FILE--
+<?php
+
+$db = new PDO('sqlite::memory:');
+$st = $db->query('SELECT 1');
+$re = $st->fetchObject('%Z');
+?>
+--EXPECTREGEX--
+Fatal error: Class '%Z' not found in .+bug70914.php on line \d+
diff --git a/Zend/zend_execute_API.c b/Zend/zend_execute_API.c
index 9d255ed..9979aac 100644
--- a/Zend/zend_execute_API.c
+++ b/Zend/zend_execute_API.c
@@ -220,7 +220,7 @@ static void zend_throw_or_error(int fetch_type, zend_class_entry *exception_ce,
if (fetch_type & ZEND_FETCH_CLASS_EXCEPTION) {
zend_throw_error(exception_ce, message);
} else {
- zend_error(E_ERROR, message);
+ zend_error(E_ERROR, "%s", message);
}
efree(message);