com php-src: Drop two compiler TODOs: Zend/zend_compile.c
| From: | Nikita Popov | Date: | Thu, 10 Dec 2015 18:04:59 +0000 |
| Subject: | com php-src: Drop two compiler TODOs: Zend/zend_compile.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-90211@lists.php.net to get a copy of this message | ||
Commit: f1278edefc9ce9ac43a9883018f9c482abfd69dd
Author: Nikita Popov <nikic@php.net> Thu, 10 Dec 2015 19:04:08 +0100
Parents: c8a64e289c23aee4fdeb8c906f504cf4d61adeea
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f1278edefc9ce9ac43a9883018f9c482abfd69dd
Log:
Drop two compiler TODOs
Call-time pass by reference is now a parse error.
There is no benefit in dropping implementing_class currently.
Changed paths:
M Zend/zend_compile.c
Diff:
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index f59228a..53c62ab 100644
--- a/Zend/zend_compile.c
+++ b/Zend/zend_compile.c
@@ -2903,7 +2903,6 @@ void zend_compile_compound_assign(znode *result, zend_ast *ast) /* {{{ */
uint32_t zend_compile_args(zend_ast *ast, zend_function *fbc) /* {{{ */
{
- /* TODO.AST &var error */
zend_ast_list *args = zend_ast_get_list(ast);
uint32_t i;
zend_bool uses_arg_unpack = 0;
@@ -5492,7 +5491,6 @@ void zend_compile_class_decl(zend_ast *ast) /* {{{ */
opline = get_next_op(CG(active_op_array));
zend_make_var_result(&declare_node, opline);
- // TODO.AST drop this
GET_NODE(&FC(implementing_class), opline->result);
opline->op2_type = IS_CONST;