com php-src: Make 2nd arg of xml_set_object by value: ext/xml/xml.c
| From: | Nikita Popov | Date: | Thu, 10 Dec 2015 22:35:25 +0000 |
| Subject: | com php-src: Make 2nd arg of xml_set_object by value: ext/xml/xml.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-90219@lists.php.net to get a copy of this message | ||
Commit: fc2cedfb1d9a391773d2236c178c839bad2ed657
Author: Nikita Popov <nikic@php.net> Thu, 10 Dec 2015 23:33:55 +0100
Parents: 047c84521c996910bddb7fdd551be4e5b34979f4
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=fc2cedfb1d9a391773d2236c178c839bad2ed657
Log:
Make 2nd arg of xml_set_object by value
The argument is not being modified. Probably holdover from PHP 4
days.
Changed paths:
M ext/xml/xml.c
Diff:
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
index bcded62..6969c5b 100644
--- a/ext/xml/xml.c
+++ b/ext/xml/xml.c
@@ -111,7 +111,7 @@ ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_INFO_EX(arginfo_xml_set_object, 0, 0, 2)
ZEND_ARG_INFO(0, parser)
- ZEND_ARG_INFO(1, obj)
+ ZEND_ARG_INFO(0, obj)
ZEND_END_ARG_INFO()
ZEND_BEGIN_ARG_INFO_EX(arginfo_xml_set_element_handler, 0, 0, 3)
@@ -1169,7 +1169,7 @@ PHP_FUNCTION(xml_set_object)
xml_parser *parser;
zval *pind, *mythis;
- if (zend_parse_parameters(ZEND_NUM_ARGS(), "ro/", &pind, &mythis) == FAILURE) {
+ if (zend_parse_parameters(ZEND_NUM_ARGS(), "ro", &pind, &mythis) == FAILURE) {
return;
}