Re: com php-src: Use worklist for DFG construction: ext/opcache/Optimizer/zend_dfg.c
| From: | Nikita Popov | Date: | Tue, 12 Jan 2016 12:55:15 +0000 |
| Subject: | Re: com php-src: Use worklist for DFG construction: ext/opcache/Optimizer/zend_dfg.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-90619@lists.php.net to get a copy of this message | ||
On Tue, Jan 12, 2016 at 9:07 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi Nikita,
>
> Cool and obvious improvement.
> I noticed that DFG calculation slowness and thought about switching to
> minimal-SSA instead of pruned.
> Now it's not necessary anymore.
> Did you get the idea yourself or read somewhere?
>
> Thanks. Dmitry.
I took the suggestion to use a worklist and postorder traversal from
Wikipedia [1]. I did not bother with real postorder traversal as it's
already fast enough, so just using the last block in the worklist instead.
Nikita
[1]: https://en.wikipedia.org/wiki/Data-flow_analysis#The_work_list_approach