Re: com php-src: PS(id) is zend_string *, use appropriate API: ext/session/session.c
| From: | Yasuo Ohgaki | Date: | Fri, 15 Jan 2016 20:36:59 +0000 |
| Subject: | Re: com php-src: PS(id) is zend_string *, use appropriate API: ext/session/session.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-90665@lists.php.net to get a copy of this message | ||
On Fri, Jan 15, 2016 at 11:47 PM, Anatol Belski <ab@php.net> wrote:
> --- a/ext/session/session.c
> +++ b/ext/session/session.c
> @@ -530,7 +530,7 @@ static void php_session_initialize(void) /* {{{ */
> /* If there is no ID, use session module to create one */
> if (!PS(id) || !ZSTR_VAL(PS(id))[0]) {
> if (PS(id)) {
> - efree(PS(id));
> + zend_string_release(PS(id));
Thank you.
It may be better to start writing patch for 7.0 then backport to avoid
pitfall of new APIs, TSRM macros, etc... Anyway, I'll try to be more
careful.
--
Yasuo Ohgaki
yohgaki@ohgaki.net