com php-src: Fixed bug #71070 Custom session handler write method returns false, warning message misleading This is commited to master only. If you
have better error message suggestion, feel free to improve it.: ext/session/session.c

Commit: 05e87fa41855c58de6435eb1c80a1bc6454362f7 Author: Yasuo Ohgaki <yohgaki@php.net> Mon, 18 Jan 2016 12:03:41 +0900 Parents: 3a8c4a00843907e7cb88615ecfc57ee25ee44bf9 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=05e87fa41855c58de6435eb1c80a1bc6454362f7 Log: Fixed bug #71070 Custom session handler write method returns false, warning message misleading This is commited to master only. If you have better error message suggestion, feel free to improve it. Bugs: https://bugs.php.net/71070 Changed paths: M ext/session/session.c Diff: diff --git a/ext/session/session.c b/ext/session/session.c index 8427f85..4385dca 100644 --- a/ext/session/session.c +++ b/ext/session/session.c @@ -611,11 +611,16 @@ static void php_session_save_current_state(int write) /* {{{ */ } if ((ret == FAILURE) && !EG(exception)) { - php_error_docref(NULL, E_WARNING, "Failed to write session data (%s). Please " - "verify that the current setting of session.save_path " - "is correct (%s)", - PS(mod)->s_name, - PS(save_path)); + if (!PS(mod_user_implemented)) { + php_error_docref(NULL, E_WARNING, "Failed to write session data (%s). Please " + "verify that the current setting of session.save_path " + "is correct (%s)", + PS(mod)->s_name, + PS(save_path)); + } else { + php_error_docref(NULL, E_WARNING, "Failed to write session data using user " + "defined save handler. (session.save_path: %s)", PS(save_path)); + } } } }