Re: com php-src: Crude generator GC for value/key/retval: Zend/tests/bug69989_1.phpt Zend/zend_generators.c

From: Date: Thu, 11 Feb 2016 15:45:06 +0000
Subject: Re: com php-src: Crude generator GC for value/key/retval: Zend/tests/bug69989_1.phpt Zend/zend_generators.c
References: 1 2  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-90992@lists.php.net to get a copy of this message
On Thu, Feb 11, 2016 at 12:05 PM, Derick Rethans <derick@php.net> wrote: > On Wed, 10 Feb 2016, Nikita Popov wrote: > > > diff --git a/Zend/zend_generators.c b/Zend/zend_generators.c > > index 4861e45..c572a9c 100644 > > --- a/Zend/zend_generators.c > > +++ b/Zend/zend_generators.c > > @@ -193,6 +193,15 @@ static void zend_generator_free_storage(zend_object > *object) /* {{{ */ > > } > > /* }}} */ > > > > +static HashTable *zend_generator_get_gc(zval *object, zval **table, int > *n) /* {{{ */ > > +{ > > + zend_generator *generator = (zend_generator*) Z_OBJ_P(object); > > + *table = &generator->value; > > + *n = 3; > > What's this magic value "3" here? > Three zvals value, key, retval. I've added a comment to the next iteration of the GC code: https://github.com/php/php-src/commit/f75be35312e3ca0495f8f5d53ffd042aae58e907#diff-977da4797a4dd97d0abaa7d43197fae2R220 Nikita

« previous php.cvs (#90992) next »