Re: com php-src: Fixed bug #71906: AddressSanitizer: negative-size-param (-1) in mbfl_strcut: ext/mbstring/libmbfl/mbfl/mbfilter.c

From: Date: Tue, 29 Mar 2016 08:22:07 +0000
Subject: Re: com php-src: Fixed bug #71906: AddressSanitizer: negative-size-param (-1) in mbfl_strcut: ext/mbstring/libmbfl/mbfl/mbfilter.c
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-91517@lists.php.net to get a copy of this message
Hi Stas, On Tue, Mar 29, 2016 at 4:16 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote: > >> It seems effective changes are these excluding WS changes. >> >> These changes are >> >> X + A >= B >> to >> A >= B - X >> >> Does this really fix issue? > > I think it does. Unless you can show me wrong :) I take a look at the code. It looks OK. libmbfl uses int for parameters while it should use uint at least... It should be changed to size_t by 7.1 release. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net

« previous php.cvs (#91517) next »