Re: com php-src: Warn about invalid strings in arithmetic: NEWS UPGRADING Zend/tests/add_006.phpt Zend/tests/add_007.phpt
Zend/tests/constant_expressions_dynamic.phpt Zend/tests/int_conversion_exponents.phpt Zend/tests/numeric_string_errors.phpt
| From: | Dmitry Stogov | Date: | Wed, 30 Mar 2016 07:35:37 +0000 |
| Subject: | Re: com php-src: Warn about invalid strings in arithmetic: NEWS UPGRADING Zend/tests/add_006.phpt Zend/tests/add_007.phpt Zend/tests/constant_expressions_dynamic.phpt Zend/tests/int_conversion_exponents.phpt Zend/tests/numeric_string_errors.phpt |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-91546@lists.php.net to get a copy of this message | ||
Hi Andrea,
2 tests are failed on Linux/32-bit.
> Invalid numeric string E_WARNINGs and E_NOTICEs [Zend/tests/numeric_string_errors.phpt]
> Invalid numeric string E_WARNINGs and E_NOTICEs, combined assignment operations
> [Zend/tests/numeric_string_errors_assign.phpt]
$ cat ../Zend/tests/numeric_string_errors.diff
071+ int(0)
071- int(360639813910528)
$ cat ../Zend/tests/numeric_string_errors_assign.diff
071+ int(0)
071- int(360639813910528)
Thanks. Dmitry.
________________________________________
From: Andrea Faulds <ajf@php.net>
Sent: Wednesday, March 30, 2016 03:44
To: php-cvs@lists.php.net
Subject: [PHP-CVS] com php-src: Warn about invalid strings in arithmetic: NEWS UPGRADING
Zend/tests/add_006.phpt Zend/tests/add_007.phpt Zend/tests/constant_expressions_dynamic.phpt
Zend/tests/int_conversion_exponents.phpt Zend/tests/numeric_string_errors.phpt ...
Commit: 1e82ad8038d3100b7e27be870652c1f639a7200a
Author: Andrea Faulds <ajf@ajf.me> Wed, 30 Mar 2016 01:44:27 +0100
Parents: e514d859150aa60b425e960b6467b4b124b466dd
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=1e82ad8038d3100b7e27be870652c1f639a7200a
Log:
Warn about invalid strings in arithmetic
Squashed commit of the following:
commit e05d3b67325d4521418483ed924ac9211a188919
Author: Andrea Faulds <ajf@ajf.me>
Date: Wed Mar 30 01:43:35 2016 +0100
UPGRADING and NEWS
commit 6caf1d4585207d1b02fb06a216cd7da1a1f5e12d
Author: Andrea Faulds <ajf@ajf.me>
Date: Sun Mar 20 21:18:33 2016 +0000
Fixes
commit 6dadb1b0efe5e2ed071e95a55c806519e61377ac
Author: Andrea Faulds <ajf@ajf.me>
Date: Sun Feb 14 02:15:01 2016 +0000
Add test for numeric string errors in assignment
commit bd5f04e8dd576f92a48d25546f4f9a0f57f374de
Author: Andrea Faulds <ajf@ajf.me>
Date: Sat Feb 13 23:53:05 2016 +0000
Add test for numeric string errors
commit c72e92f16d512bcae30cc9639c89bcb08d971742
Author: Andrea Faulds <ajf@ajf.me>
Date: Tue Jan 26 23:28:33 2016 +0000
Add test for scientific notation in integer operations
commit d94c08852d405b3a7ef6c84d24bf7915c890ce78
Author: Andrea Faulds <ajf@ajf.me>
Date: Sun Feb 14 01:25:57 2016 +0000
Disable optimiser evaluation for numeric string errors
commit 30ee954ed13d933e766c68605d683c8ebae3d8ee
Author: Andrea Faulds <ajf@ajf.me>
Date: Sun Feb 14 01:46:25 2016 +0000
fixup
commit a6403b79e054c95e2b7345d787f3092b261eed27
Author: Andrea Faulds <ajf@ajf.me>
Date: Sat Feb 13 22:00:27 2016 +0000
Do not convert error-causing numeric strings ahead-of-time
commit f9dc35401471ef3035954cb6f171826769297548
Author: Andrea Faulds <ajf@ajf.me>
Date: Sat Feb 13 19:15:38 2016 +0000
Disable compile-time evaluation for numeric string errors
commit e05b0cc8496ea082c6db27efd8b8277ef1f785b5
Author: Andrea Faulds <ajf@ajf.me>
Date: Fri Feb 5 11:42:26 2016 +0000
Make _zval_get_long_func_noisy function for inlining
commit 84d66321a57e579759109650c8bb7e3d5002854a
Author: Andrea Faulds <ajf@ajf.me>
Date: Tue Jan 26 23:10:00 2016 +0000
Update tests
commit 5ac4a0cc4bff282e3a15eaa8ab44b67391881a6d
Author: Andrea Faulds <ajf@ajf.me>
Date: Tue Jan 26 22:08:19 2016 +0000
Use is_numeric_string_ex for zval_get_long etc.
commit c21f08848533723331012a62a153de3577731d6a
Author: Andrea Faulds <ajf@ajf.me>
Date: Thu Jan 7 21:13:04 2016 +0000
Update tests
commit 63e214cf8160420bfc51c6a2b4ae32f09ad8e8af
Author: Andrea Faulds <ajf@ajf.me>
Date: Wed Jan 6 00:28:01 2016 +0000
Warn on non-/bad numeric strings in arithmetic
Changed paths:
M NEWS
M UPGRADING
M Zend/tests/add_006.phpt
M Zend/tests/add_007.phpt
M Zend/tests/constant_expressions_dynamic.phpt
A Zend/tests/int_conversion_exponents.phpt
A Zend/tests/numeric_string_errors.phpt
A Zend/tests/numeric_string_errors_assign.phpt
M Zend/tests/self_and.phpt
M Zend/tests/self_mod.phpt
M Zend/tests/self_or.phpt
M Zend/tests/self_xor.phpt
M Zend/tests/shift_001.phpt
M Zend/tests/shift_002.phpt
M Zend/zend_API.c
M Zend/zend_compile.c
M Zend/zend_compile.h
M Zend/zend_operators.c
M Zend/zend_operators.h
M ext/opcache/Optimizer/block_pass.c
M ext/opcache/Optimizer/pass1_5.c
M ext/opcache/Optimizer/pass2.c
M ext/standard/tests/file/file_put_contents_variation7.phpt
M ext/standard/tests/general_functions/floatval.phpt
M ext/standard/tests/general_functions/floatval_variation1.phpt
M ext/standard/tests/general_functions/gettype_settype_variation2.phpt
M ext/standard/tests/math/decbin_basic.phpt
M ext/standard/tests/math/dechex_basic.phpt
M ext/standard/tests/math/decoct_basic.phpt
M ext/standard/tests/math/pow_variation1.phpt
M ext/standard/tests/math/pow_variation1_64bit.phpt
M ext/standard/tests/math/pow_variation2.phpt
M ext/standard/tests/strings/bug55871.phpt
M ext/standard/type.c
M tests/lang/bug28800.phpt
M tests/lang/operators/bitwiseShiftLeft_variationStr_64bit.phpt
M tests/lang/operators/bitwiseShiftRight_variationStr.phpt
M tests/lang/operators/modulus_variationStr.phpt
M tests/lang/operators/negate_variationStr.phpt