Re: cvs: php4 /ext/standard math.c

If you send me the patches Ill commit them if you want or you can try and get Karma from someone who can give it to you. Cheers, - James > On Sun, Jan 27, 2002 at 10:05:54AM -0000, James Moore wrote: > > > > It would be pretty nifty if the zend_* versions of these > > > functions did the right thing for Win32 initially, but I'm not > > > sure how to tackle that one because PHP_WIN32 doesn't appear to > > > be valid in php_config.h (where these macros are defined). > > > > Take a look at config.w32.h in php4/main. But shouldnt these be defined in > > Zend? > > Okay, I see where they should be defined now, but it looks like > zend_config.w32.h already defines zend_isinf(). Perhaps is > should also define zend_finite() and zend_isnan() for the Win32 > case? I'd make that change, but I don't have Zend karma. > > In the non-Windows cases, it looks like zend_config.h merely > includes "../main/php_config.h", which is where all the magic > happens. I'm not sure if that is optimial, but that's the way > it's been for a while now. > > -- > Jon Parise (jon@csh.rit.edu) . Information Technology (2001) > http://www.csh.rit.edu/~jon/ : Computer Science House Member > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net > For additional commands, e-mail: php-cvs-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net