Re: cvs: php4 /ext/domxml php_domxml.c

On Mon, Feb 04, 2002 at 09:07:40PM -0000, Jaroslaw Kolakowski wrote : > jarkol Mon Feb 4 16:07:40 2002 EDT > > Modified files: > /php4/ext/domxml php_domxml.c > Log: > > Fixed compile error > > > > Index: php4/ext/domxml/php_domxml.c > diff -u php4/ext/domxml/php_domxml.c:1.115 php4/ext/domxml/php_domxml.c:1.116 > --- php4/ext/domxml/php_domxml.c:1.115 Mon Feb 4 06:39:15 2002 > +++ php4/ext/domxml/php_domxml.c Mon Feb 4 16:07:39 2002 > @@ -16,7 +16,7 @@ > +----------------------------------------------------------------------+ > */ > > -/* $Id: php_domxml.c,v 1.115 2002/02/04 11:39:15 yohgaki Exp $ */ > +/* $Id: php_domxml.c,v 1.116 2002/02/04 21:07:39 jarkol Exp $ */ > > /* TODO > * - Support Notation Nodes > @@ -3469,10 +3469,10 @@ > { > const xmlChar *string = (const xmlChar *)str; > > - TSRMLS_FETCH(); > - > xmlChar *value; > > + TSRMLS_FETCH(); > + > if (xmlStrchr(string, '"')) { > if (xmlStrchr(string, '\'')) { > php_error(E_WARNING, "Cannot create XPath expression (string contains both quote and > double-quotes) in %s", Instead of introducing redundant calls to *FETCH it would be much better to just pass around the context from the PHP_FUNCTION()... -- Please always Cc to me when replying to me on the lists.