Re: cvs: php4 /ext/domxml php_domxml.c
| From: | Markus Fischer | Date: | Tue, 05 Feb 2002 07:43:04 +0000 |
| Subject: | Re: cvs: php4 /ext/domxml php_domxml.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-9276@lists.php.net to get a copy of this message | ||
On Tue, Feb 05, 2002 at 09:30:04AM +0900, Yasuo Ohgaki wrote :
> Markus Fischer wrote:
> >On Mon, Feb 04, 2002 at 11:39:16AM -0000, Yasuo Ohgaki wrote :
> >
> >>yohgaki Mon Feb 4 06:39:16 2002 EDT
> >>
> >> Modified files:
> >> /php4/ext/domxml php_domxml.c
> >> Log:
> >> Fix ZTS build
> >>
> >
> > Please revert this commit. Passing the context around is
> > better then fetching it everytime (I can fix this later
> > today).
> >
>
> That's what I thought, too :)
> I would like to make change as little as possibe
> when I'm patching code that I don't know well.
Very wise ;)
>
> Why not just rewrite it?
For me, because I don't get paid for it and don't have that
much spare time.
--
Please always Cc to me when replying to me on the lists.