com php-src: Remove needless zeroing of anonymously mmap'd memory: sapi/fpm/fpm/fpm_shm.c sapi/litespeed/lsapilib.c

Commit: 9dd5d96332b2562010de6b1a48fdcb5d3db43ea0 Author: Michael McConville <mmcco@mykolab.com> Tue, 26 Apr 2016 13:16:38 -0400 Committer: Julien Pauli <jpauli@php.net> Mon, 11 Jul 2016 14:56:17 +0200 Parents: 6a5e1783b73d9072665db48f959eb7e36970bc4b Branches: PHP-5.6 PHP-7.0 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=9dd5d96332b2562010de6b1a48fdcb5d3db43ea0 Log: Remove needless zeroing of anonymously mmap'd memory All existing systems zero anonymously mmapped memory, and if I understand correctly POSIX will be specifying this soon. Many projects already rely on it, so no reasonable system would return memory of unspecified value. Changed paths: M sapi/fpm/fpm/fpm_shm.c M sapi/litespeed/lsapilib.c Diff: diff --git a/sapi/fpm/fpm/fpm_shm.c b/sapi/fpm/fpm/fpm_shm.c index 9226adf...7986056 100644 --- a/sapi/fpm/fpm/fpm_shm.c +++ b/sapi/fpm/fpm/fpm_shm.c @@ -35,7 +35,6 @@ void *fpm_shm_alloc(size_t size) /* {{{ */ return NULL; } - memset(mem, 0, size); fpm_shm_size += size; return mem; } diff --git a/sapi/litespeed/lsapilib.c b/sapi/litespeed/lsapilib.c index 75bd30e..be3df2f7 100644 --- a/sapi/litespeed/lsapilib.c +++ b/sapi/litespeed/lsapilib.c @@ -2639,7 +2639,6 @@ static int lsapi_init_children_status() perror( "Anonymous mmap() failed" ); return -1; } - memset( pBuf, 0, size ); g_prefork_server->m_pChildrenStatus = (lsapi_child_status *)pBuf; g_prefork_server->m_pChildrenStatusCur = (lsapi_child_status *)pBuf; g_prefork_server->m_pChildrenStatusEnd = (lsapi_child_status *)pBuf + size / sizeof( lsapi_child_status );