Re: com php-src: oops, name test right: ext/pcntl/tests/pcntl_signal_get_handler.phpt

Looks like Fedora wasn't printing "User defined signal 1" when SIGUSR1 was received by the process using SIG_DFL. I'm not sure why David did this in the test, but I changed the test a bit in [1] so that SIG_IGN is the handler when the signal is received. Aaron Piotrowski [1] http://git.php.net/?p=php-src.git;a=commit;h=1ba20e311e4f9046c192f9cc23cdaaf04ec5fa70 > On Jul 11, 2016, at 3:02 AM, Dmitry Stogov <dmitry@zend.com> wrote: > > Hi Aaron, > > For some reason this test fails for me on Fedora 25. > > $ cat ../ext/pcntl/tests/pcntl_signal_get_handler.log > > ---- EXPECTED OUTPUT > int(0) > string(10) "pcntl_test" > int(1) > int(0) > User defined signal 1 > > Termsig=10 > ---- ACTUAL OUTPUT > int(0) > string(10) "pcntl_test" > int(1) > int(0) > > Termsig=10 > ---- FAILED > > Thanks. Dmitry. > From: Aaron Piotrowski <trowski@php.net > <mailto:trowski@php.net>> > Sent: Wednesday, July 6, 2016 9:57:37 PM > To: php-cvs@lists.php.net <mailto:php-cvs@lists.php.net> > Subject: [PHP-CVS] com php-src: oops, name test right: > ext/pcntl/tests/pcntl_signal_get_handler.phpt > > Commit: ed9bff5352c7e48e205b599bb17c68d872aa97b6 > Author: David Walker <dave@mudsite.com > <mailto:dave@mudsite.com>> Wed, 6 Jul 2016 08:02:49 > -0600 > Committer: Aaron Piotrowski <aaron@trowski.com > <mailto:aaron@trowski.com>> Wed, 6 Jul 2016 13:57:37 > -0500 > Parents: 90e326c620236927993bb3f19594e01f199f450a > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=ed9bff5352c7e48e205b599bb17c68d872aa97b6 > > <http://git.php.net/?p=php-src.git;a=commitdiff;h=ed9bff5352c7e48e205b599bb17c68d872aa97b6> > > Log: > oops, name test right > > Changed paths: > M ext/pcntl/tests/pcntl_signal_get_handler.phpt > > > Diff: > diff --git a/ext/pcntl/tests/pcntl_signal_get_handler.phpt > b/ext/pcntl/tests/pcntl_signal_get_handler.phpt > index 7d66f65..286f399 100644 > --- a/ext/pcntl/tests/pcntl_signal_get_handler.phpt > +++ b/ext/pcntl/tests/pcntl_signal_get_handler.phpt > @@ -1,5 +1,5 @@ > --TEST-- > -pcntl_signal() > +pcntl_signal_get_handler() > --SKIPIF-- > <?php if (!extension_loaded("pcntl")) print "skip"; ?> > <?php if (!extension_loaded("posix")) die("skip posix extension not > available"); ?> > > > -- > PHP CVS Mailing List (http://www.php.net/ > <http://www.php.net/>) > To unsubscribe, visit: http://www.php.net/unsub.php > <http://www.php.net/unsub.php>