com php-src: Fix #72604: imagearc() ignores thickness for full arcs: NEWS ext/gd/libgd/gd.c ext/gd/tests/bug72604.phpt

Commit: 3666cfab973c5aba86d0562d14de8ed74e66cdb7 Author: Christoph M. Becker <cmb@php.net> Fri, 15 Jul 2016 19:42:26 +0200 Parents: a4aa4f9772a6c30f69db8560cde1f5fe4545b174 Branches: PHP-5.6 PHP-7.0 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=3666cfab973c5aba86d0562d14de8ed74e66cdb7 Log: Fix #72604: imagearc() ignores thickness for full arcs We remove the special casing for full arcs, what conforms to external libgd. Bugs: https://bugs.php.net/72604 Changed paths: M NEWS M ext/gd/libgd/gd.c A ext/gd/tests/bug72604.phpt Diff: diff --git a/NEWS b/NEWS index 455e44b..caf8073 100644 --- a/NEWS +++ b/NEWS @@ -29,6 +29,7 @@ PHP NEWS - GD: . Fixed bug #72596 (imagetypes function won't advertise WEBP support). (cmb) + . Fixed bug #72604 (imagearc() ignores thickness for full arcs). (cmb) - Intl: . Partially fixed #72506 (idn_to_ascii for UTS #46 incorrect for long domain diff --git a/ext/gd/libgd/gd.c b/ext/gd/libgd/gd.c index a5799c5..3b5d829 100644 --- a/ext/gd/libgd/gd.c +++ b/ext/gd/libgd/gd.c @@ -1673,11 +1673,7 @@ long lsqrt (long n) void gdImageArc (gdImagePtr im, int cx, int cy, int w, int h, int s, int e, int color) { - if ((s % 360) == (e % 360)) { - gdImageEllipse(im, cx, cy, w, h, color); - } else { - gdImageFilledArc(im, cx, cy, w, h, s, e, color, gdNoFill); - } + gdImageFilledArc(im, cx, cy, w, h, s, e, color, gdNoFill); } void gdImageFilledArc (gdImagePtr im, int cx, int cy, int w, int h, int s, int e, int color, int style) diff --git a/ext/gd/tests/bug72604.phpt b/ext/gd/tests/bug72604.phpt new file mode 100644 index 0000000..b1dea5e --- /dev/null +++ b/ext/gd/tests/bug72604.phpt @@ -0,0 +1,19 @@ +--TEST-- +Bug #72604 (imagearc() ignores thickness for full arcs) +--SKIPIF-- +<?php +if (!extension_loaded('gd')) die('skip requires ext/gd'); +if (!(imagetypes() & IMG_PNG)) die('skip requires PNG support'); +?> +--FILE-- +<?php +$im = imagecreatetruecolor(100, 100); +imagesetthickness($im, 5); +imagearc($im, 50, 50, 90, 90, 0, 360, 0xffffff); +ob_start(); +imagepng($im); +$imagestring = ob_get_clean(); +echo md5($imagestring); +?> +--EXPECT-- +2ffa6afb915afbdf870cf6459477bc8a