RE: [PHP-CVS] com php-src: Support Unicode characters in the local part of an e-mail address.: ext/filter/filter.c ext/filter/filter_private.h
ext/filter/logical_filters.c ext/filter/tests/058.phpt

Hi Derick, > -----Original Message----- > From: Derick Rethans [mailto:derick@php.net] > Sent: Monday, July 18, 2016 10:47 PM > To: Anatol Belski <ab@php.net>; php-cvs@lists.php.net > Subject: Re: [PHP-CVS] com php-src: Support Unicode characters in the local > part of an e-mail address.: ext/filter/filter.c ext/filter/filter_private.h > ext/filter/logical_filters.c ext/filter/tests/058.phpt > > On July 18, 2016 8:52:35 PM GMT+01:00, Anatol Belski <ab@php.net> wrote: > >Commit: 8f4050709c833b9d42cd65349b7747f8e61d171f > >Author: Leo Feyer <github@contao.org> Thu, 15 Oct 2015 > >11:07:25 +0200 > >Committer: Anatol Belski <ab@php.net> Mon, 18 Jul 2016 21:52:35 > >+0200 > >Parents: 42260325a47480bc97f7dceb2ac5d8e8d7799928 > >Branches: master > > > >Link: > >http://git.php.net/?p=php- > src.git;a=commitdiff;h=8f4050709c833b9d42cd65349b7747f8e61d171f > > > >Log: > >Support Unicode characters in the local part of an e-mail address. > > > >See RFC 6531 (https://tools.ietf.org/html/rfc6531). > > > >Encode IDNA domains. > > > >Add the missing "Done" to the expected output. > > > >Add the FILTER_FLAG_EMAIL_RFC6531 flag. > > > >Fix the filter_var() call. > > > >Changed paths: > > M ext/filter/filter.c > > M ext/filter/filter_private.h > > M ext/filter/logical_filters.c > > A ext/filter/tests/058.phpt > > Wouldn't it be nicer to have a descriptive constant name instead of an RFC > number? > Yeah, you just confirm my doubts on that. I'll rename to FILTER_FLAG_EMAIL_UNICODE, that would comply with the naming in ext/intl. Regards Anatol