Re: com php-src: Fix for bug #71863 Segfault when EXPLAIN with "Unknown column" error: NEWS ext/mysqli/tests/bug71863.phpt
ext/mysqlnd/mysqlnd_connection.c ext/mysqlnd/mysqlnd_result.c
| From: | Nikita Popov | Date: | Fri, 22 Jul 2016 22:06:49 +0000 |
| Subject: | Re: com php-src: Fix for bug #71863 Segfault when EXPLAIN with "Unknown column" error: NEWS ext/mysqli/tests/bug71863.phpt ext/mysqlnd/mysqlnd_connection.c ext/mysqlnd/mysqlnd_result.c |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-93334@lists.php.net to get a copy of this message | ||
On Fri, Jul 22, 2016 at 11:26 PM, Andrey Hristov <andrey@php.net> wrote:
> Commit: 671d22f5de1396ee9b7b42467a41ff0a58df9389
> Author: Andrey Hristov <andrey@php.net> Sat, 23 Jul 2016
> 00:26:26 +0300
> Parents: 40b312d4c2d129f2085af585566fa417b43419e8
> Branches: master
>
> Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=671d22f5de1396ee9b7b42467a41ff0a58df9389
>
> Log:
> Fix for bug #71863 Segfault when EXPLAIN with "Unknown column" error
>
> The reason was that after the big refactoring of mysqlnd at the end of
> last year code that is initializing the error_info structure in the
> result set was not added. It existed already for connections and PS.
> The code that segfaults is hit only with MariaDB because MariaDB sends
> full metadata about the EXPLAIN query + EOF packet and only then it sends
> an error packet. MySQL doesn't do that but sends directly an error which
> is caught (by different code path). As errors during execution (which means
> after sending meta) are pretty rare there was no test case of MySQL to
> catch it.
>
It looks like the push to PHP-7.1 didn't succeed and this ended up only in
master (even though there's a merge commit).
Nikita