Re: com php-src: Fix broken test case: ext/gd/tests/gd_info_variation1.phpt
| From: | Christoph Becker | Date: | Mon, 25 Jul 2016 07:38:11 +0000 |
| Subject: | Re: com php-src: Fix broken test case: ext/gd/tests/gd_info_variation1.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-93374@lists.php.net to get a copy of this message | ||
Hi Matteo!
On 25.07.2016 at 08:59, Matteo Beccati wrote:
> Hi,
>
> the test now fails on my C.I. setup:
>
>
> https://revive.beccati.com/bamboo/browse/PHP-SRC2-TESTS-811/test/case/11424741
Indeed, I committed a buggy fix - sorry. That should already have been
fixed with <https://github.com/php/php-src/commit/305bddb>.
Cheers!
> Cheers
>
> Il 25/07/16 00:13, Christoph Michael Becker ha scritto:
>> Commit: d28f1dae9dbe09b63539efe94a0ef449f6790438
>> Author: Christoph M. Becker <cmb@php.net> Mon, 25 Jul 2016
>> 00:13:44 +0200
>> Parents: 9cd23ff84f67edb8bbc7aad63d48d81a0e63ae46
>> Branches: PHP-5.6 PHP-7.0 PHP-7.1 master
>>
>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=d28f1dae9dbe09b63539efe94a0ef449f6790438
>>
>>
>> Log:
>> Fix broken test case
>>
>> The test claims that it would be "checking all the values in returned
>> array",
>> but due to the use of %a it actually skipped elements. We fix that by
>> using
>> %s instead.
>>
>> Changed paths:
>> M ext/gd/tests/gd_info_variation1.phpt
>>
>>
>> Diff:
>> diff --git a/ext/gd/tests/gd_info_variation1.phpt
>> b/ext/gd/tests/gd_info_variation1.phpt
>> index a725f65..fffde0b 100644
>> --- a/ext/gd/tests/gd_info_variation1.phpt
>> +++ b/ext/gd/tests/gd_info_variation1.phpt
>> @@ -25,26 +25,28 @@ var_dump(gd_info());
>> *** Testing gd_info() : variation ***
>> array(%d) {
>> ["GD Version"]=>
>> - string(%d) %a
>> + string(%d) %s
>> ["FreeType Support"]=>
>> - bool%a
>> + bool(%s)
>> ["T1Lib Support"]=>
>> - bool%a
>> + bool(%s)
>> ["GIF Read Support"]=>
>> - bool%a
>> + bool(%s)
>> ["GIF Create Support"]=>
>> - bool%a
>> + bool(%s)
>> ["JPEG Support"]=>
>> - bool%a
>> + bool(%s)
>> ["PNG Support"]=>
>> - bool%a
>> + bool(%s)
>> ["WBMP Support"]=>
>> - bool%a
>> + bool(%s)
>> ["XPM Support"]=>
>> - bool%a
>> + bool(%s)
>> ["XBM Support"]=>
>> - bool%a
>> + bool(%s)
>> + ["WebP Support"]=>
>> + bool(%s)
>> ["JIS-mapped Japanese Font Support"]=>
>> - bool%a
>> + bool(%s)
>> }
>> ===DONE===
>> \ No newline at end of file
>>
>>
>