RE: [PHP-CVS] com php-src: upgraded to PCRE 8.39: ext/pcre/pcrelib/AUTHORS ext/pcre/pcrelib/ChangeLog ext/pcre/pcrelib/LICENCE ext/pcre/pcrelib/NEWS
ext/pcre/pcrelib/README ext/pcre/pcrelib/dftables.c ext/pcre/pcrelib/doc/pcre.txt ext/pcre/pcrelib/pcre.h
| From: | Anatol Belski | Date: | Sat, 30 Jul 2016 15:47:04 +0000 |
| Subject: | RE: [PHP-CVS] com php-src: upgraded to PCRE 8.39: ext/pcre/pcrelib/AUTHORS ext/pcre/pcrelib/ChangeLog ext/pcre/pcrelib/LICENCE ext/pcre/pcrelib/NEWS ext/pcre/pcrelib/README ext/pcre/pcrelib/dftables.c ext/pcre/pcrelib/doc/pcre.txt ext/pcre/pcrelib/pcre.h |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-93494@lists.php.net to get a copy of this message | ||
Hi Nikita,
> -----Original Message-----
> From: Nikita Popov [mailto:nikita.ppv@gmail.com]
> Sent: Saturday, July 30, 2016 1:05 AM
> To: Anatol Belski <ab@php.net>
> Cc: php-cvs@lists.php.net
> Subject: Re: [PHP-CVS] com php-src: upgraded to PCRE 8.39:
> ext/pcre/pcrelib/AUTHORS ext/pcre/pcrelib/ChangeLog
> ext/pcre/pcrelib/LICENCE ext/pcre/pcrelib/NEWS ext/pcre/pcrelib/README
> ext/pcre/pcrelib/dftables.c ext/pcre/pcrelib/doc/pcre.txt
> ext/pcre/pcrelib/pcre.h
>
> On Tue, Jul 26, 2016 at 3:07 PM, Anatol Belski <ab@php.net> wrote:
>
> > Commit: 2fba6468374a15efc82aaac8cbfc600b29c5404f
> > Author: Anatol Belski <ab@php.net> Sun, 19 Jun 2016 20:38:31
> > +0200
> > Parents: b1d36cb820480f09ae0daa10b3f822ad5eb0db11
> > Branches: PHP-7.0 PHP-7.1 master
> >
> > Link:
> > http://git.php.net/?p=php-src.git;a=commitdiff;h=2fba6468374a15efc82aa§P
> > YQ*žk¹„¤k/á
> > ac8cbfc600b29c5404f
> >
> > Log:
> > upgraded to PCRE 8.39
> >
> > (cherry picked from commit 9d4fe9672a1c32d1349f267d24d079e3ebdc83e8)
> >
> > Changed paths:
> > M ext/pcre/pcrelib/AUTHORS
> > M ext/pcre/pcrelib/ChangeLog
> > M ext/pcre/pcrelib/LICENCE
> > M ext/pcre/pcrelib/NEWS
> > M ext/pcre/pcrelib/README
> > M ext/pcre/pcrelib/dftables.c
> > M ext/pcre/pcrelib/doc/pcre.txt
> > M ext/pcre/pcrelib/pcre.h
> > M ext/pcre/pcrelib/pcre_compile.c
> > M ext/pcre/pcrelib/pcre_config.c
> > M ext/pcre/pcrelib/pcre_exec.c
> > M ext/pcre/pcrelib/pcre_fullinfo.c
> > M ext/pcre/pcrelib/pcre_get.c
> > M ext/pcre/pcrelib/pcre_globals.c
> > M ext/pcre/pcrelib/pcre_internal.h
> > M ext/pcre/pcrelib/pcre_jit_compile.c
> > M ext/pcre/pcrelib/pcre_maketables.c
> > M ext/pcre/pcrelib/pcre_newline.c
> > M ext/pcre/pcrelib/pcre_ord2utf8.c
> > M ext/pcre/pcrelib/pcre_printint.c
> > M ext/pcre/pcrelib/pcre_refcount.c
> > M ext/pcre/pcrelib/pcre_study.c
> > M ext/pcre/pcrelib/pcre_tables.c
> > M ext/pcre/pcrelib/pcre_ucd.c
> > M ext/pcre/pcrelib/pcre_valid_utf8.c
> > M ext/pcre/pcrelib/pcre_version.c
> > M ext/pcre/pcrelib/pcre_xclass.c
> > M ext/pcre/pcrelib/pcreposix.c
> > M ext/pcre/pcrelib/sljit/sljitConfigInternal.h
> > M ext/pcre/pcrelib/sljit/sljitExecAllocator.c
> > M ext/pcre/pcrelib/sljit/sljitLir.c
> > M ext/pcre/pcrelib/sljit/sljitLir.h
> > M ext/pcre/pcrelib/sljit/sljitNativeARM_32.c
> > M ext/pcre/pcrelib/sljit/sljitNativeARM_64.c
> > M ext/pcre/pcrelib/sljit/sljitNativeARM_T2_32.c
> > M ext/pcre/pcrelib/sljit/sljitNativeMIPS_32.c
> > M ext/pcre/pcrelib/sljit/sljitNativeMIPS_64.c
> > M ext/pcre/pcrelib/sljit/sljitNativeMIPS_common.c
> > M ext/pcre/pcrelib/sljit/sljitNativePPC_32.c
> > M ext/pcre/pcrelib/sljit/sljitNativePPC_64.c
> > M ext/pcre/pcrelib/sljit/sljitNativePPC_common.c
> > M ext/pcre/pcrelib/sljit/sljitNativeSPARC_32.c
> > M ext/pcre/pcrelib/sljit/sljitNativeSPARC_common.c
> > M ext/pcre/pcrelib/sljit/sljitNativeTILEGX_64.c
> > M ext/pcre/pcrelib/sljit/sljitNativeX86_32.c
> > M ext/pcre/pcrelib/sljit/sljitNativeX86_64.c
> > M ext/pcre/pcrelib/sljit/sljitNativeX86_common.c
> > M ext/pcre/pcrelib/sljit/sljitUtils.c
> > M ext/pcre/pcrelib/testdata/testinput11
> > M ext/pcre/pcrelib/testdata/testinput2
> > M ext/pcre/pcrelib/testdata/testinput6
> > M ext/pcre/pcrelib/testdata/testinput7
> > M ext/pcre/pcrelib/testdata/testoutput11-16
> > M ext/pcre/pcrelib/testdata/testoutput11-32
> > M ext/pcre/pcrelib/testdata/testoutput11-8
> > M ext/pcre/pcrelib/testdata/testoutput2
> > A ext/pcre/pcrelib/testdata/testoutput3A
> > A ext/pcre/pcrelib/testdata/testoutput3B
> > M ext/pcre/pcrelib/testdata/testoutput6
> > M ext/pcre/pcrelib/testdata/testoutput7
> > A ext/pcre/pcrelib/testdata/valgrind-jit.supp
> >
> >
> > Diff: <Diff exceeded maximum size>
> >
>
> Many PCRE tests started generating valgrind errors of the following type (e.g.
> ext/pcre/tests/bug52971.phpt):
>
> ==14967== Invalid read of size 16
> ==14967== at 0x406B0D0: ???
> ==14967== by 0xF8071FA: ???
> ==14967== by 0xF8071B7: ???
> ==14967== by 0xF807215: ???
> ==14967== by 0xFFEFFBB8F: ???
> ==14967== by 0xF8071B7: ???
> ==14967== Address 0xf807210 is 112 bytes inside a block of size 120 alloc'd
> ==14967== at 0x4C2AB80: malloc (in
> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==14967== by 0xA55627: _emalloc (zend_alloc.c:2446)
> ==14967== by 0xA2DF2F: zend_string_alloc (zend_string.h:121)
> ==14967== by 0xA2DF98: zend_string_init (zend_string.h:157)
> ==14967== by 0xA36C00: lex_scan (zend_language_scanner.l:2001)
> ==14967== by 0xA5B4EA: zendlex (zend_compile.c:1587)
> ==14967== by 0xA28E96: zendparse (zend_language_parser.c:4673)
> ==14967== by 0xA2FA28: compile_file (zend_language_scanner.l:591)
> ==14967== by 0x7C9F27: phar_compile_file (phar.c:3322)
> ==14967== by 0xA8906E: zend_execute_scripts (zend.c:1421)
> ==14967== by 0x9F5E59: php_execute_script (main.c:2494)
> ==14967== by 0xB49E34: do_cli (php_cli.c:974)
>
> I suspect that this is caused by this PCRE upgrade.
>
Thanks! Finally found a system to reproduce this. The case is weird - directly running the valgrind
command the backtrace is clean. But make test shows it :/ Haven't seen any issues with other
tools, including travis.
I'd take a day yet to investigate, 8.39 is supposed to contain JIT improvements backported from
PCRE2. It might be good the cause, that these weird backtraces are because some unusual valgrind
options are required. But most likely this should be reverted in 7.0+ before next release, until the
picture is clear.
Regards
Anatol