com php-src: The call to FreeLibrary() should be within the if, so we don't pass INVALID_HANDLE_VALUE to it, in case LoadLi brary() fails:
win32/time.c
| From: | Kalle Sommer Nielsen | Date: | Thu, 11 Aug 2016 02:13:34 +0000 |
| Subject: | com php-src: The call to FreeLibrary() should be within the if, so we don't pass INVALID_HANDLE_VALUE to it, in case LoadLi brary() fails: win32/time.c |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-93736@lists.php.net to get a copy of this message | ||
Commit: ff1a3cecae250bdde8955597dc94594161938cdf
Author: Kalle Sommer Nielsen <kalle@php.net> Thu, 11 Aug 2016 04:13:34 +0200
Parents: 36b050c2c517b1b9bc1c67e07722d01f6eed6aa4
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ff1a3cecae250bdde8955597dc94594161938cdf
Log:
The call to FreeLibrary() should be within the if, so we don't pass INVALID_HANDLE_VALUE to it,
in case LoadLibrary() fails
Changed paths:
M win32/time.c
Diff:
diff --git a/win32/time.c b/win32/time.c
index 9063ebf..dcc0943 100644
--- a/win32/time.c
+++ b/win32/time.c
@@ -38,10 +38,10 @@ static zend_always_inline MyGetSystemTimeAsFileTime get_time_func(void)
if (hMod) {
/* Max possible resolution <1us, win8/server2012 */
timefunc = (MyGetSystemTimeAsFileTime)GetProcAddress(hMod,
"GetSystemTimePreciseAsFileTime");
- }
- /* Lower the refcount */
- FreeLibrary(hMod);
+ /* Lower the refcount */
+ FreeLibrary(hMod);
+ }
if(!timefunc) {
/* 100ns blocks since 01-Jan-1641 */