Re: com php-src: Get rid of these slow calls to LoadLibrary()/GetProcAddress() calls on Windows, we require Windows Vista as bare minimum for PHP
anyway, so it does not make any sense to do this slow emulation anyway.: ext/gd/gd.c ext/standard/f
| From: | Kalle Sommer Nielsen | Date: | Fri, 12 Aug 2016 06:19:29 +0000 |
| Subject: | Re: com php-src: Get rid of these slow calls to LoadLibrary()/GetProcAddress() calls on Windows, we require Windows Vista as bare minimum for PHP anyway, so it does not make any sense to do this slow emulation anyway.: ext/gd/gd.c ext/standard/f |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-93758@lists.php.net to get a copy of this message | ||
Hi Anatol
2016-08-11 15:58 GMT+02:00 Anatol Belski <anatol.php@belski.net>:
> Hi Kalle,
> I ported some of these into 7.1 already. Seems you revealed some missing parts while digging in
> there. There might be still more in some far code places which are not handled by streams, those
> related to path handling have to be done in 7.1 as that's a missing part of the
> implementation.
Thank you! I did see that some of the functions were using their
"*A()" function, not the "*W()" variant. I did look at some of the new
implementations you have been working, which looks really nice,
although I'm not too familiar with the API itself to be able to
convert functions I spot over. If I find some places, I will try to
add a tag that can be grep'd to easily :)
> In general, checking symbols is required at some places as sometimes one has to deal with
> different system/DLL versions. It is fine in MINIT phase (or in DLLMain in PHP7) to setup a correct
> function pointer. On runtime it should be avoided whenever possible. But we'd better not touch
> the bundled libs without strong need, and at least send patches to the corresponding upstream, when
> patched.
Indeed, that was why I did not really want to touch libsqlite in
particular, but I think we did get rid of a fair few for now. I will
continue to look further into more as I go about the source.
Thanks!
--
regards,
Kalle Sommer Nielsen
kalle@php.net