Re: com php-src: Fix #72714: _xml_startElementHandler() segmentation fault: NEWS ext/xml/tests/bug72714.phpt ext/xml/xml.c
| From: | Christoph M. Becker | Date: | Sat, 20 Aug 2016 10:26:19 +0000 |
| Subject: | Re: com php-src: Fix #72714: _xml_startElementHandler() segmentation fault: NEWS ext/xml/tests/bug72714.phpt ext/xml/xml.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-94013@lists.php.net to get a copy of this message | ||
On 20.08.2016 at 12:09, Nikita Popov wrote:
> On Sat, Aug 20, 2016 at 1:58 AM, Christoph Michael Becker <cmb@php.net>
> wrote:
>
>> Commit: 9164dc11e2323b8b80c389bb13d70789799b44fc
>>
>> +#define SKIP_TAGSTART(str) ((str) + (parser->toffset > strlen(str) ?
>> strlen(str) : + parser->toffset))
>
> There's a stray unary + in the else branch. Is this there to suppress some
> warning or just a typo?
Good catch, thanks! Actually, it is a left over from refactoring.
>> + php_error_docref(NULL TSRMLS_CC, E_NOTICE,
>> "tagstart ignored");
>
> "tagstart ignored, because it is out of range"?
Good suggestion.
I'll fix the issues ASAP.
--
Christoph M. Becker